Bug 75693 - Move FrameDestructionObserver to its own file
Summary: Move FrameDestructionObserver to its own file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 75697
  Show dependency treegraph
 
Reported: 2012-01-06 02:30 PST by Adam Barth
Modified: 2012-01-06 14:55 PST (History)
3 users (show)

See Also:


Attachments
Patch (11.97 KB, patch)
2012-01-06 02:32 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (11.42 KB, patch)
2012-01-06 02:34 PST, Adam Barth
eric: review+
abarth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-01-06 02:30:48 PST
Move FrameDestructionObserver to its own file
Comment 1 Adam Barth 2012-01-06 02:32:02 PST
Created attachment 121415 [details]
Patch
Comment 2 Adam Barth 2012-01-06 02:34:18 PST
Created attachment 121416 [details]
Patch
Comment 3 Eric Seidel (no email) 2012-01-06 02:59:26 PST
Comment on attachment 121416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121416&action=review

LGTM.

> Source/WebCore/page/FrameDestructionObserver.h:42
> +    Frame* m_frame;

Having the storage on FrameDestructionObserver is probably slightly controvertial.  Theoretically one might want a FrameDestructionObserver that had its own Frame storage, but the common case probably wants this concrete instance.  We may eventually want to separate out the ABC from this common concrete instance.
Comment 4 Adam Barth 2012-01-06 03:05:01 PST
Yes, that's a good point.  So far, all the subclasses I've seen want this storage, but that might change in the future.
Comment 5 Eric Seidel (no email) 2012-01-06 03:12:52 PST
I should have acxtually mentioned it in my previous review, since it was the other bug which moved the storage down into the (previously) ABC.  Anyway, I think turning FrameDestructionObserver into a concrete class with Frame* storage is good.  We might want to add a coment about how it's a slight violation of the interface paradigm. :)
Comment 6 Adam Barth 2012-01-06 03:33:42 PST
Comment on attachment 121416 [details]
Patch

Forgot the Xcodeproj file.
Comment 7 Adam Barth 2012-01-06 14:55:00 PST
Committed r104344: <http://trac.webkit.org/changeset/104344>