Bug 75629 – NRWT fails to open results.html for Apple's Windows port

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Roben (:aroben)]

When NRWT tries to open results.html on Apple's Windows port, all that happens is this error message gets printed:

Failed to open file:///home/Adam%20Roben/dev/Build_WebKit/Debug/bin/layout-test-results/results.html

[Adam Roben (:aroben)]

Looks like the default implementation:

return self.host.user.open_url(self._filesystem.file_path_as_url(results_filename))

…doesn't work in Cygwin.

[Radar WebKit Bug Importer]

<rdar://problem/10648621>

[Adam Roben (:aroben)]

Ah, that's because User.open_url uses the webbrowser module, which doesn't work in Cygwin.

[Eric Seidel (no email)]

We'll probably have to make User smarter at some point.  This is not the only trouble we've had with this.  See bug 75438 for the most recent fix to this code.

[Adam Roben (:aroben)]

(In reply to comment #4)
> We'll probably have to make User smarter at some point.  This is not the only trouble we've had with this.  See bug 75438 for the most recent fix to this code.

A simple fix for User on Cygwin would be to use something like executive.run_command(['cygstart', url]).

But in this specific case we probably want to use run-safari instead.

[Eric Seidel (no email)]

I thought the ApplePort already overrode this method to use run-safari? Maybe I'm remembering wrong.

[Adam Roben (:aroben)]

(In reply to comment #6)
> I thought the ApplePort already overrode this method to use run-safari? Maybe I'm remembering wrong.

MacPort does that. We should move that logic up to ApplePort. We'll still need to override it on Windows so we can pass the path through cygpath first.

[Eric Seidel (no email)]

I see.  Looks like the mac port does:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py#L160

But the Apple base class does not:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/apple.py

That's probably right, since we have to pass specific args to run-safari for Mac.  Sounds like Win should just ovveride like Mac does.

[Adam Roben (:aroben)]

Created attachment 121305 [details]
Teach NRWT to use run-safari to open results.html on Apple's Windows port

[Eric Seidel (no email)]

Comment on attachment 121305 [details]
Teach NRWT to use run-safari to open results.html on Apple's Windows port

LGTM.

[Adam Roben (:aroben)]

Committed r104191: <http://trac.webkit.org/changeset/104191>