Bug 75539 - getComputedStyle for background is not implemented.
Summary: getComputedStyle for background is not implemented.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexis Menard (darktears)
URL:
Keywords:
Depends on:
Blocks: 13658
  Show dependency tree / graph
 
Reported: 2012-01-04 05:24 PST by Alexis Menard (darktears)
Modified: 2012-01-05 09:31 PST (History)
5 users (show)

See Also:

Attachments
Patch (13.36 KB, patch)
2012-01-04 05:26 PST, Alexis Menard (darktears) 		no flags Details | Formatted Diff | Diff
Patch (23.04 KB, patch)
2012-01-04 11:43 PST, Alexis Menard (darktears) 		tony: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2012-01-04 05:24:12 PST 
getComputedStyle for background is not implemented.
Comment 1 Alexis Menard (darktears) 2012-01-04 05:26:03 PST 
Created attachment 121102 [details]
Patch
Comment 2 Tony Chang 2012-01-04 10:19:46 PST 
Comment on attachment 121102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121102&action=review

> LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-shorthand.html:36
> +e.style.backgroundImage = "url(dummy://test.png)";

Where are the tests for setting backgroundRepeat, backgroundAttachment or backgroundPosition?  Also, it would be nice to add an identify check like the one mentioned in the border image patch.
Comment 3 Alexis Menard (darktears) 2012-01-04 11:43:06 PST 
Created attachment 121131 [details]
Patch
Comment 4 Tony Chang 2012-01-04 11:47:23 PST 
Comment on attachment 121131 [details]
Patch

Thanks!
Comment 5 WebKit Review Bot 2012-01-05 01:10:12 PST 
Comment on attachment 121131 [details]
Patch

Attachment 121131 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11131175

New failing tests:
http/tests/appcache/simple.html
Comment 6 Alexis Menard (darktears) 2012-01-05 03:31:34 PST 
Comment on attachment 121131 [details]
Patch

Let's give another try. It passed with the previous version of the patch but the second only add more coverage of the new feature.
Comment 7 WebKit Review Bot 2012-01-05 05:40:30 PST 
Comment on attachment 121131 [details]
Patch

Rejecting attachment 121131 [details] from commit-queue.

New failing tests:
http/tests/appcache/simple.html
Full output: http://queues.webkit.org/results/11120310
Comment 8 Alexis Menard (darktears) 2012-01-05 09:31:40 PST 
Committed r104169: <http://trac.webkit.org/changeset/104169>