75474 – [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix

Bug 75474 - [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix

Summary: [GTK] run-gtk-test should ignore files with names without a "test" or "Test" ...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Tools / Tests (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:	Gtk

Depends on:
Blocks:	72589
	Show dependency tree / graph

Reported:	2012-01-03 08:19 PST by Mario Sanchez Prada
Modified:	2012-01-03 09:00 PST (History)
CC List:	3 users (show)

See Also:

Attachments
Patch proposal (2.00 KB, patch) 2012-01-03 08:26 PST, Mario Sanchez Prada	no flags	Details \| Formatted Diff \| Diff
Patch proposal (2.00 KB, patch) 2012-01-03 08:37 PST, Mario Sanchez Prada	pnormand: review+	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mario Sanchez Prada 2012-01-03 08:19:05 PST

Currently, any executable file placed under the WK2GTK's API tests directory will be executed, no matter it has or not the "test" or "Test" prefix, which is a problem at least for the patch about bug 72589, since we need to place there a helper program that is not a test, but an "accessibility test server" to be inspected from TestWebKitAccessibility (the actual test).

Initial solution in bug 72589 to this was to include the WebKit2APITests/AccessibilityTestServer file in the SKIPPED list in run-gtk-tests, but it seems that a better solution would be just to make run-gtk-tests to ignore files without the "test" (used for WK1's API tests) and the "Test" (used in WK2) prefix.

So, this bug is about that.

Comment 1 Mario Sanchez Prada 2012-01-03 08:26:33 PST

Created attachment 120949 [details]
Patch proposal

Comment 2 Carlos Garcia Campos 2012-01-03 08:37:20 PST

Comment on attachment 120949 [details]
Patch proposal

Looks good to me, I would probably use if not test_file.lower().startswith("test") but I guess it's a matter of taste.

Comment 3 Mario Sanchez Prada 2012-01-03 08:37:58 PST

Created attachment 120953 [details]
Patch proposal

A better approach

Comment 4 Mario Sanchez Prada 2012-01-03 09:00:26 PST

Committed r103943: <http://trac.webkit.org/changeset/103943>