Add first version of InjectedBundleEfl.cpp including load() and placeholder for activateMacFontAscentHack().
Created attachment 120922 [details] patch for InjectedBundleEfl
Attachment 120922 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 120926 [details] patch for InjectedBundleEfl
Comment on attachment 120926 [details] patch for InjectedBundleEfl View in context: https://bugs.webkit.org/attachment.cgi?id=120926&action=review > Source/WebKit2/WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:-44 > - notImplemented(); Why did you remove notImplemented() in here? I think it is better to keep it until this function is implemented.
(In reply to comment #4) > (From update of attachment 120926 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120926&action=review > > > Source/WebKit2/WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:-44 > > - notImplemented(); > > Why did you remove notImplemented() in here? I think it is better to keep it until this function is implemented. ===> notImplemented() was removed in all other ports. Please see InjectedBundleMac.cpp and so on.
Comment on attachment 120926 [details] patch for InjectedBundleEfl View in context: https://bugs.webkit.org/attachment.cgi?id=120926&action=review > Source/WebKit2/WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:44 > + if (!initializeFunction) I think it is better to add debugging message when failing to get initializeFuncction like qt, gtk.
Created attachment 121989 [details] patch for InjectedBundleEfl add debugging messages
Comment on attachment 121989 [details] patch for InjectedBundleEfl View in context: https://bugs.webkit.org/attachment.cgi?id=121989&action=review > Source/WebKit2/WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:42 > + m_platformBundle = eina_module_new(m_path.utf8().data()); > + if (!m_platformBundle || !eina_module_load(m_platformBundle)) { > + EINA_LOG_CRIT("Error loading the injected bundle: %s", m_path.utf8().data()); > + return false; If eina_module_new() is successful but eina_module_load() is not, don't you need to call eina_module_free() before returning?
(In reply to comment #8) > (From update of attachment 121989 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=121989&action=review > > > Source/WebKit2/WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:42 > > + m_platformBundle = eina_module_new(m_path.utf8().data()); > > + if (!m_platformBundle || !eina_module_load(m_platformBundle)) { > > + EINA_LOG_CRIT("Error loading the injected bundle: %s", m_path.utf8().data()); > > + return false; > > If eina_module_new() is successful but eina_module_load() is not, don't you need to call eina_module_free() before returning? Thank you for your kind review. I fixed it in the next patch.
Created attachment 122394 [details] patch for InjectedBundleEfl
LGTM.
Comment on attachment 122394 [details] patch for InjectedBundleEfl Clearing flags on attachment: 122394 Committed r108961: <http://trac.webkit.org/changeset/108961>
All reviewed patches have been landed. Closing bug.