Bug 75463 - [EFL][WK2] Add InjectedBundleEfl.cpp
Summary: [EFL][WK2] Add InjectedBundleEfl.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 61838
  Show dependency treegraph
 
Reported: 2012-01-03 00:42 PST by YoungTaeck Song
Modified: 2012-02-26 23:48 PST (History)
4 users (show)

See Also:


Attachments
patch for InjectedBundleEfl (2.73 KB, patch)
2012-01-03 02:44 PST, YoungTaeck Song
no flags Details | Formatted Diff | Diff
patch for InjectedBundleEfl (2.74 KB, patch)
2012-01-03 03:43 PST, YoungTaeck Song
no flags Details | Formatted Diff | Diff
patch for InjectedBundleEfl (2.89 KB, patch)
2012-01-11 00:23 PST, YoungTaeck Song
no flags Details | Formatted Diff | Diff
patch for InjectedBundleEfl (3.14 KB, patch)
2012-01-13 01:52 PST, YoungTaeck Song
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description YoungTaeck Song 2012-01-03 00:42:44 PST
Add first version of InjectedBundleEfl.cpp including load() and placeholder for activateMacFontAscentHack().
Comment 1 YoungTaeck Song 2012-01-03 02:44:18 PST
Created attachment 120922 [details]
patch for InjectedBundleEfl
Comment 2 WebKit Review Bot 2012-01-03 02:47:46 PST
Attachment 120922 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 YoungTaeck Song 2012-01-03 03:43:18 PST
Created attachment 120926 [details]
patch for InjectedBundleEfl
Comment 4 Gyuyoung Kim 2012-01-03 16:39:30 PST
Comment on attachment 120926 [details]
patch for InjectedBundleEfl

View in context: https://bugs.webkit.org/attachment.cgi?id=120926&action=review

> Source/WebKit2/WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:-44
> -    notImplemented();

Why did you remove notImplemented() in here? I think it is better to keep it until this function is implemented.
Comment 5 YoungTaeck Song 2012-01-03 16:51:04 PST
(In reply to comment #4)
> (From update of attachment 120926 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=120926&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:-44
> > -    notImplemented();
> 
> Why did you remove notImplemented() in here? I think it is better to keep it until this function is implemented.

===> notImplemented() was removed in all other ports. Please see InjectedBundleMac.cpp and so on.
Comment 6 Gyuyoung Kim 2012-01-10 23:22:51 PST
Comment on attachment 120926 [details]
patch for InjectedBundleEfl

View in context: https://bugs.webkit.org/attachment.cgi?id=120926&action=review

> Source/WebKit2/WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:44
> +    if (!initializeFunction)

I think it is better to add debugging message when failing to get initializeFuncction like qt, gtk.
Comment 7 YoungTaeck Song 2012-01-11 00:23:52 PST
Created attachment 121989 [details]
patch for InjectedBundleEfl

add debugging messages
Comment 8 Andreas Kling 2012-01-12 00:47:08 PST
Comment on attachment 121989 [details]
patch for InjectedBundleEfl

View in context: https://bugs.webkit.org/attachment.cgi?id=121989&action=review

> Source/WebKit2/WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:42
> +    m_platformBundle = eina_module_new(m_path.utf8().data());
> +    if (!m_platformBundle || !eina_module_load(m_platformBundle)) {
> +        EINA_LOG_CRIT("Error loading the injected bundle: %s", m_path.utf8().data());
> +        return false;

If eina_module_new() is successful but eina_module_load() is not, don't you need to call eina_module_free() before returning?
Comment 9 YoungTaeck Song 2012-01-13 01:51:47 PST
(In reply to comment #8)
> (From update of attachment 121989 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121989&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:42
> > +    m_platformBundle = eina_module_new(m_path.utf8().data());
> > +    if (!m_platformBundle || !eina_module_load(m_platformBundle)) {
> > +        EINA_LOG_CRIT("Error loading the injected bundle: %s", m_path.utf8().data());
> > +        return false;
> 
> If eina_module_new() is successful but eina_module_load() is not, don't you need to call eina_module_free() before returning?

Thank you for your kind review.
I fixed it in the next patch.
Comment 10 YoungTaeck Song 2012-01-13 01:52:21 PST
Created attachment 122394 [details]
patch for InjectedBundleEfl
Comment 11 Ryuan Choi 2012-02-26 22:07:30 PST
LGTM.
Comment 12 WebKit Review Bot 2012-02-26 23:48:05 PST
Comment on attachment 122394 [details]
patch for InjectedBundleEfl

Clearing flags on attachment: 122394

Committed r108961: <http://trac.webkit.org/changeset/108961>
Comment 13 WebKit Review Bot 2012-02-26 23:48:10 PST
All reviewed patches have been landed.  Closing bug.