Bug 75443 - getComputedStyle for list-style is not implemented.
Summary: getComputedStyle for list-style is not implemented.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexis Menard (darktears)
URL:
Keywords:
Depends on:
Blocks: 13658
  Show dependency treegraph
 
Reported: 2012-01-02 12:33 PST by Alexis Menard (darktears)
Modified: 2012-01-03 15:21 PST (History)
9 users (show)

See Also:


Attachments
Patch (9.67 KB, patch)
2012-01-02 12:34 PST, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff
Patch for landing (11.16 KB, patch)
2012-01-03 10:45 PST, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2012-01-02 12:33:33 PST
getComputedStyle for list-style is not implemented.
Comment 1 Alexis Menard (darktears) 2012-01-02 12:34:32 PST
Created attachment 120891 [details]
Patch
Comment 2 Tony Chang 2012-01-03 10:34:51 PST
Comment on attachment 120891 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120891&action=review

> LayoutTests/fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.html:56
> +shouldBe("computedStyle.getPropertyCSSValue('list-style').item(2).getStringValue()", "'none'");

I would maybe add some tests that set listStyleType, listStylePosition, or listStyleImage and make sure that list-style is properly updated.  Up to you.
Comment 3 Alexis Menard (darktears) 2012-01-03 10:45:50 PST
Created attachment 120958 [details]
Patch for landing
Comment 4 WebKit Review Bot 2012-01-03 15:21:00 PST
Comment on attachment 120958 [details]
Patch for landing

Clearing flags on attachment: 120958

Committed r103974: <http://trac.webkit.org/changeset/103974>
Comment 5 WebKit Review Bot 2012-01-03 15:21:06 PST
All reviewed patches have been landed.  Closing bug.