Bug 75347 – getComputedStyle for border-image is not implemented.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Alexis Menard (darktears)]

getComputedStyle for border-image is not implemented.

[Alexis Menard (darktears)]

Created attachment 120736 [details]
Patch

[Tony Chang]

Comment on attachment 120736 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120736&action=review

> Source/WebCore/ChangeLog:8
> +        Implement getComputedStyle for border-color.

Nit: border-image

> LayoutTests/fast/css/getComputedStyle/computed-style-border-image.html:23
> +shouldBe("computedBorderImageStyle('12 11 12 11', 'border-image')", "'none 12 11 1 0px stretch'");

It doesn't look like this is something that WebKit can parse properly.  I think you need a '/' between border-image-slice, border-image-width and border-image-outset.

[Alexis Menard (darktears)]

Created attachment 121098 [details]
Patch

[Alexis Menard (darktears)]

Created attachment 121099 [details]
Patch

[Tony Chang]

Comment on attachment 121099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121099&action=review

> LayoutTests/fast/css/getComputedStyle/computed-style-border-image.html:56
> +shouldBe("computedBorderImageStyle('url(dummy://test.png) 10 / 13px / 11px', 'border-image')", "'url(dummy://test.png) 10 / 13px / 11px stretch'");

Can you add some tests that setting border-image to the value returned by getComputedStyle doesn't change the value.  That is, for each of the different values:
var before = window.getComputedStyle(testDiv).getPropertyValue('border-image');
testDiv.style.borderImage = 'none';
testDiv.style.borderImage = before;
assert(window.getComputedStyle(testDiv).getPropertyValue('border-image') == before);

It would be nice to have this kind of check for all future getComputedStyle changes.

[Alexis Menard (darktears)]

Created attachment 121129 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 121129 [details]
Patch for landing

Clearing flags on attachment: 121129

Committed r104144: <http://trac.webkit.org/changeset/104144>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.