Bug 75273 - Web Inspector: [protocol] empty enum constant should be replaced with identifier
Summary: Web Inspector: [protocol] empty enum constant should be replaced with identifier
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-27 15:42 PST by Peter Rybin
Modified: 2011-12-28 04:28 PST (History)
11 users (show)

See Also:


Attachments
Patch (18.07 KB, patch)
2011-12-28 02:32 PST, Alexander Pavlov (apavlov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Rybin 2011-12-27 15:42:05 PST
In Inspector.json domain=CSS/type=CSSRule/property=origin is of enum type. This enum has following values:
["user", "user-agent", "inspector", ""]

Empty constant should be considered uncool as in https://bugs.webkit.org/show_bug.cgi?id=74954#c23 :
"
> Source/WebCore/inspector/CodeGeneratorInspector.py:54
> +    "": "Empty",

Please change this to some non-empty constant ("regular" should be find for CSSRule.origin as we discussed offline) or  file a bug about this.
"
/ Comment #23 From Yury Semikhatsky 2011-12-27 11:28:36 PST
Comment 1 Alexander Pavlov (apavlov) 2011-12-28 02:32:44 PST
Created attachment 120646 [details]
Patch
Comment 2 WebKit Review Bot 2011-12-28 04:28:24 PST
Comment on attachment 120646 [details]
Patch

Clearing flags on attachment: 120646

Committed r103761: <http://trac.webkit.org/changeset/103761>
Comment 3 WebKit Review Bot 2011-12-28 04:28:30 PST
All reviewed patches have been landed.  Closing bug.