RESOLVED FIXED 75273
Web Inspector: [protocol] empty enum constant should be replaced with identifier 
https://bugs.webkit.org/show_bug.cgi?id=75273
Summary Web Inspector: [protocol] empty enum constant should be replaced with identifier
Peter Rybin
Reported 2011-12-27 15:42:05 PST
In Inspector.json domain=CSS/type=CSSRule/property=origin is of enum type. This enum has following values: ["user", "user-agent", "inspector", ""] Empty constant should be considered uncool as in https://bugs.webkit.org/show_bug.cgi?id=74954#c23 : " > Source/WebCore/inspector/CodeGeneratorInspector.py:54 > + "": "Empty", Please change this to some non-empty constant ("regular" should be find for CSSRule.origin as we discussed offline) or file a bug about this. " / Comment #23 From Yury Semikhatsky 2011-12-27 11:28:36 PST
Attachments
Patch (18.07 KB, patch)
2011-12-28 02:32 PST, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2011-12-28 02:32:44 PST
Created attachment 120646 [details] Patch
WebKit Review Bot
Comment 2 2011-12-28 04:28:24 PST
Comment on attachment 120646 [details] Patch Clearing flags on attachment: 120646 Committed r103761: <http://trac.webkit.org/changeset/103761>
WebKit Review Bot
Comment 3 2011-12-28 04:28:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.