Generate enum types in C++ TypeBuilder. As we discussed with caseq@, JSON enums are morphed into C++ enums with its numeric values pointing to an actual string value in pre-build array. This also requires setter methods to become overloaded so that both old string-based and new enum-based code styles could co-exist.
Created attachment 120340 [details] Patch
Created attachment 120341 [details] Sample InspectorFrontend.h
Created attachment 120342 [details] Sample InspectorFrontend.cpp
Created attachment 120356 [details] Patch
Comment on attachment 120356 [details] Patch Attachment 120356 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10997623
Comment on attachment 120356 [details] Patch Attachment 120356 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10997627
Comment on attachment 120356 [details] Patch Attachment 120356 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11001595
Comment on attachment 120356 [details] Patch Attachment 120356 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10997636
Created attachment 120367 [details] Patch
Created attachment 120456 [details] For win trybot
Created attachment 120460 [details] Patch
Created attachment 120461 [details] Sample InspectorFrontend.h
Created attachment 120463 [details] For win trybot
Created attachment 120465 [details] For win trybot
I'd like to see enum constants declared as CamelCase according to WebKit style guide. Rule Names:12. Enum members should user InterCaps with an initial capital letter. If it is not possible then I prefer the chromium style kCamelCase
Created attachment 120595 [details] For trybots
Created attachment 120599 [details] InspectorFrontend.h base version
Created attachment 120600 [details] InspectorFrontend.cpp base version
Created attachment 120601 [details] Patch
Created attachment 120602 [details] New InspectorFrontend.h
Created attachment 120603 [details] New InspectorFrontend.cpp
Created attachment 120604 [details] Generator output diff
Comment on attachment 120601 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120601&action=review > Source/WebCore/inspector/CodeGeneratorInspector.py:54 > + "": "Empty", Please change this to some non-empty constant ("regular" should be find for CSSRule.origin as we discussed offline) or file a bug about this.
Comment on attachment 120601 [details] Patch Clearing flags on attachment: 120601 Committed r103763: <http://trac.webkit.org/changeset/103763>
All reviewed patches have been landed. Closing bug.
Reopening since the patch was rolled out in https://bugs.webkit.org/show_bug.cgi?id=75307 due to Mac compile failures.
Created attachment 120671 [details] Patch
Created attachment 120673 [details] New InspectorFrontend.h
Created attachment 120674 [details] New InspectorFrontend.cpp
Created attachment 120675 [details] Generator output diff
Created attachment 120676 [details] Same patch to test it on Mac bot
Comment on attachment 120671 [details] Patch Clearing flags on attachment: 120671 Committed r104707: <http://trac.webkit.org/changeset/104707>