Bug 75200 – REGRESSION (r90797): Full screen video HUD cannot be dragged horizontally

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

To reproduce, navigate to the URL, click the full screen button in the video controls to enter full screen mode, then try to drag the full screen HUD around the screen. The HUD only moves vertically but stays centered. This was caused by <http://trac.webkit.org/r90797>.

<rdar://problem/10625200>

[Jer Noble]

Created attachment 121331 [details]
Patch

[Eric Carlson]

Comment on attachment 121331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121331&action=review

r=me, although I would rather you use mediaControlsElement() if possible.

> LayoutTests/fullscreen/video-controls-drag.html:19
> +                panel = internals.shadowRoot(video).firstChild.firstChild;

Ick, why hard code the position of the element in the shadow DOM instead of looking it up by name?

[Jer Noble]

(In reply to comment #3)
> (From update of attachment 121331 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121331&action=review
> 
> r=me, although I would rather you use mediaControlsElement() if possible.
> 
> > LayoutTests/fullscreen/video-controls-drag.html:19
> > +                panel = internals.shadowRoot(video).firstChild.firstChild;
> 
> Ick, why hard code the position of the element in the shadow DOM instead of looking it up by name?

I copied it from an existing test, and discovered mediaControlsElement() in between this patch, and the one for bug #75650. :-D

I'll change this to use mediaControlsElement.  Thanks!

[WebKit Review Bot]

Comment on attachment 121331 [details]
Patch

Attachment 121331 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11146268

New failing tests:
fullscreen/video-controls-drag.html

[Jer Noble]

Committed r104301: <http://trac.webkit.org/changeset/104301>