Bug 75650 - Media Element: scrubbing in full-screen mode breaks playback.
Summary: Media Element: scrubbing in full-screen mode breaks playback.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-01-05 14:34 PST by Jer Noble
Modified: 2012-01-06 11:13 PST (History)
0 users

See Also:


Attachments
Patch (4.39 KB, patch)
2012-01-05 16:00 PST, Jer Noble
sullivan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2012-01-05 14:34:41 PST
Media Element: scrubbing in full-screen mode breaks playback.
Comment 1 Jer Noble 2012-01-05 14:36:14 PST
The media panel and the timeline both attempt to handle the mouseDown event during a scrub event, which results in the timeline never receiving a mouseUp event.
Comment 2 Jer Noble 2012-01-05 14:36:29 PST
<rdar://problem/10650963>
Comment 3 Jer Noble 2012-01-05 16:00:33 PST
Created attachment 121359 [details]
Patch
Comment 4 Eric Carlson 2012-01-05 17:06:29 PST
Comment on attachment 121359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121359&action=review

> Source/WebCore/html/shadow/MediaControlElements.cpp:243
> +        } else if (event->type() == eventNames().mousemoveEvent && m_isBeingDragged)
>              continueDrag(location);

Is there no need to call setDefaultHandled() on the move event?

> LayoutTests/ChangeLog:9
> +        * fullscreen/video-controls-timeline.html: Added.
> +

Did you forget to add the test results?
Comment 5 Jer Noble 2012-01-05 18:24:56 PST
(In reply to comment #4)
> (From update of attachment 121359 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121359&action=review
> 
> > Source/WebCore/html/shadow/MediaControlElements.cpp:243
> > +        } else if (event->type() == eventNames().mousemoveEvent && m_isBeingDragged)
> >              continueDrag(location);
> 
> Is there no need to call setDefaultHandled() on the move event?

There is no need.  The panel has already started capturing events at this point, so none of the other controls will get their default event handler called.

> > LayoutTests/ChangeLog:9
> > +        * fullscreen/video-controls-timeline.html: Added.
> > +
> 
> Did you forget to add the test results?

I did; I'll add them before checking in.
Comment 6 Jer Noble 2012-01-06 11:13:14 PST
Committed r104303: <http://trac.webkit.org/changeset/104303>