Bug 75650 – Media Element: scrubbing in full-screen mode breaks playback.

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jer Noble]

Media Element: scrubbing in full-screen mode breaks playback.

[Jer Noble]

The media panel and the timeline both attempt to handle the mouseDown event during a scrub event, which results in the timeline never receiving a mouseUp event.

[Jer Noble]

<rdar://problem/10650963>

[Jer Noble]

Created attachment 121359 [details]
Patch

[Eric Carlson]

Comment on attachment 121359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121359&action=review

> Source/WebCore/html/shadow/MediaControlElements.cpp:243
> +        } else if (event->type() == eventNames().mousemoveEvent && m_isBeingDragged)
>              continueDrag(location);

Is there no need to call setDefaultHandled() on the move event?

> LayoutTests/ChangeLog:9
> +        * fullscreen/video-controls-timeline.html: Added.
> +

Did you forget to add the test results?

[Jer Noble]

(In reply to comment #4)
> (From update of attachment 121359 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121359&action=review
> 
> > Source/WebCore/html/shadow/MediaControlElements.cpp:243
> > +        } else if (event->type() == eventNames().mousemoveEvent && m_isBeingDragged)
> >              continueDrag(location);
> 
> Is there no need to call setDefaultHandled() on the move event?

There is no need.  The panel has already started capturing events at this point, so none of the other controls will get their default event handler called.

> > LayoutTests/ChangeLog:9
> > +        * fullscreen/video-controls-timeline.html: Added.
> > +
> 
> Did you forget to add the test results?

I did; I'll add them before checking in.

[Jer Noble]

Committed r104303: <http://trac.webkit.org/changeset/104303>