Bug 75166 – Web Inspector: Implement a worker for parsing out JavaScript function data

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

This is necessary for implementing the Go to Function dialog

[Alexander Pavlov (apavlov)]

Created attachment 120443 [details]
Patch

[Pavel Feldman]

Comment on attachment 120443 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120443&action=review

> Source/WebCore/inspector/front-end/ScriptOutlineWorker.js:68
> +    buildScriptOutline();

I think you should combine this worker with the one that formats source.

> Source/WebCore/inspector/front-end/ScriptOutlineWorker.js:140
> +                setTimeout(buildScriptOutline, 0);

You should not use setTimeout in worker.

[Alexander Pavlov (apavlov)]

Created attachment 120454 [details]
Patch

[Alexander Pavlov (apavlov)]

(In reply to comment #2)
> (From update of attachment 120443 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=120443&action=review
> 
> > Source/WebCore/inspector/front-end/ScriptOutlineWorker.js:68
> > +    buildScriptOutline();
> 
> I think you should combine this worker with the one that formats source.

As agreed offline, we shall forcefully terminate the worker if a new source needs to be reparsed, so retaining this as a separate worker.

> > Source/WebCore/inspector/front-end/ScriptOutlineWorker.js:140
> > +                setTimeout(buildScriptOutline, 0);
> 
> You should not use setTimeout in worker.

Done.

[Alexander Pavlov (apavlov)]

Created attachment 120457 [details]
Patch

[Alexander Pavlov (apavlov)]

Created attachment 120462 [details]
Patch

[Alexander Pavlov (apavlov)]

Committed r103627: <http://trac.webkit.org/changeset/103627>