Bug 75166 - Web Inspector: Implement a worker for parsing out JavaScript function data
Summary: Web Inspector: Implement a worker for parsing out JavaScript function data
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks: 75092
  Show dependency tree / graph
 
Reported: 2011-12-23 00:53 PST by Alexander Pavlov (apavlov)
Modified: 2011-12-23 07:41 PST (History)
10 users (show)

See Also:

Attachments
Patch (17.63 KB, patch)
2011-12-23 01:42 PST, Alexander Pavlov (apavlov) 		no flags Details | Formatted Diff | Diff
Patch (17.05 KB, patch)
2011-12-23 03:50 PST, Alexander Pavlov (apavlov) 		no flags Details | Formatted Diff | Diff
Patch (8.69 KB, patch)
2011-12-23 04:36 PST, Alexander Pavlov (apavlov) 		no flags Details | Formatted Diff | Diff
Patch (11.54 KB, patch)
2011-12-23 05:40 PST, Alexander Pavlov (apavlov) 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2011-12-23 00:53:25 PST 
This is necessary for implementing the Go to Function dialog
Comment 1 Alexander Pavlov (apavlov) 2011-12-23 01:42:15 PST 
Created attachment 120443 [details]
Patch
Comment 2 Pavel Feldman 2011-12-23 03:12:08 PST 
Comment on attachment 120443 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120443&action=review

> Source/WebCore/inspector/front-end/ScriptOutlineWorker.js:68
> +    buildScriptOutline();

I think you should combine this worker with the one that formats source.

> Source/WebCore/inspector/front-end/ScriptOutlineWorker.js:140
> +                setTimeout(buildScriptOutline, 0);

You should not use setTimeout in worker.
Comment 3 Alexander Pavlov (apavlov) 2011-12-23 03:50:05 PST 
Created attachment 120454 [details]
Patch
Comment 4 Alexander Pavlov (apavlov) 2011-12-23 03:51:20 PST 
(In reply to comment #2)
> (From update of attachment 120443 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=120443&action=review
> 
> > Source/WebCore/inspector/front-end/ScriptOutlineWorker.js:68
> > +    buildScriptOutline();
> 
> I think you should combine this worker with the one that formats source.

As agreed offline, we shall forcefully terminate the worker if a new source needs to be reparsed, so retaining this as a separate worker.

> > Source/WebCore/inspector/front-end/ScriptOutlineWorker.js:140
> > +                setTimeout(buildScriptOutline, 0);
> 
> You should not use setTimeout in worker.

Done.
Comment 5 Alexander Pavlov (apavlov) 2011-12-23 04:36:25 PST 
Created attachment 120457 [details]
Patch
Comment 6 Alexander Pavlov (apavlov) 2011-12-23 05:40:49 PST 
Created attachment 120462 [details]
Patch
Comment 7 Alexander Pavlov (apavlov) 2011-12-23 07:41:15 PST 
Committed r103627: <http://trac.webkit.org/changeset/103627>