This should resemble a similar dialog that pops up in Eclipse upon Ctrl/Meta-O.
Patch to follow.
Please attach a screenshot too.
Created attachment 120331 [details]
Attachment 120331 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9
+ 0639b9d...3ff8cc1 master -> origin/master (forced update)
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 103548 = 0639b9de03475c2b49464647c607d0249c7445d1
r103545 = 3ff8cc11dd87e8ac3a4acaee763d8549687e5da1
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
103546 = 4e5cbb711dbbaa35b7a064791c6a6e3e2556787c already exists! Why are we refetching it?
at /usr/lib/git-core/git-svn line 5210
Died at Tools/Scripts/update-webkit line 158.
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 120332 [details]
[IMAGE] Screenshot of the Inspector with the Go to Function dialog opened
The blue bar below the query input field reports the script parsing progress
It'd be great to visualize the matching piece in the list (like making the match black vs text's gray-ish).
(In reply to comment #5)
> It'd be great to visualize the matching piece in the list (like making the match black vs text's gray-ish).
Agree, however it's going to be a CPU killer for huge matching function counts (and for multiple matches per function name). I'll try to figure it out tomorrow.
Comment on attachment 120331 [details]
Alexander is splitting this change as we agreed offline.
Created attachment 120470 [details]
This implements chunked match highlighting (see screenshot). Didn't extract Dialog - too little code in common with GoToLine
Created attachment 120472 [details]
[IMAGE] Screenshot of the Go to Function dialog with query match highlighting
Comment on attachment 120470 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=120470&action=review
Lets land highlighter as a separate change.
This css should be lazily loaded.
Created attachment 120541 [details]
Committed r103682: <http://trac.webkit.org/changeset/103682>
On Mac, does this meta-O conflict with File / Open's shortcut?