WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
74641
[MutationObservers] Add a document-level flag that can trivially be checked to avoid doing unnessary work if mutation observers absent
https://bugs.webkit.org/show_bug.cgi?id=74641
Summary
[MutationObservers] Add a document-level flag that can trivially be checked t...
Rafael Weinstein
Reported
2011-12-15 12:49:15 PST
Right now, discovering there is no work to do still costs a number of function calls and checks. We should get this down to one function call and one check at most.
Attachments
Patch
(34.16 KB, patch)
2011-12-15 13:00 PST
,
Rafael Weinstein
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Rafael Weinstein
Comment 1
2011-12-15 13:00:17 PST
Created
attachment 119486
[details]
Patch
WebKit Review Bot
Comment 2
2011-12-15 13:04:22 PST
Attachment 119486
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/WebCore.vcproj/WebCore.vcproj:43816: mismatched tag [xml/syntax] [5] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ojan Vafai
Comment 3
2011-12-15 14:19:25 PST
Comment on
attachment 119486
[details]
Patch Patch looks fine. EWS seems unhappy with your build file changes though.
Ryosuke Niwa
Comment 4
2011-12-15 15:15:34 PST
Comment on
attachment 119486
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=119486&action=review
> Source/WebCore/ChangeLog:8 > + This patch adds a byte of flags to Document, of which three bits are used to signal if any
Enum usually takes 4 bytes in 32-bit architecture and 8 bytes in 64-bit architecture due to alignments. Because the previous member variable (m_listenerTypes) is unsigned short, gcc/clang may pack it into the same 4 byte but cl.exe will almost certainly allocate 4 bytes for each. It's not big of a deal anyway though.
Adam Klein
Comment 5
2011-12-15 16:59:45 PST
Comment on
attachment 119486
[details]
Patch Clearing flags on attachment: 119486 Committed
r103001
: <
http://trac.webkit.org/changeset/103001
>
Adam Klein
Comment 6
2011-12-15 16:59:49 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug