Bug 74528 – [Qt] Support requestAnimationFrame API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Igor Trindade Oliveira]

SSIA

[Igor Trindade Oliveira]

Created attachment 119274 [details]
Patch

Proposed patch.

[Kenneth Rohde Christiansen]

Comment on attachment 119274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119274&action=review

probably fine but let Tor Arne or Simon have a look

> Source/JavaScriptCore/wtf/Platform.h:1131
> -#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(EFL) || (PLATFORM(WIN) && !OS(WINCE) && !PLATFORM(WIN_CAIRO))
> +#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(EFL) || (PLATFORM(WIN) && !OS(WINCE) && !PLATFORM(WIN_CAIRO)) || PLATFORM(QT)
>  #define WTF_USE_REQUEST_ANIMATION_FRAME_TIMER 1

I wonder if this could be an opt out instead :)

[Simon Hausmann]

Comment on attachment 119274 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119274&action=review

> Source/WebCore/Target.pri:3325
> +contains(DEFINES, ENABLE_REQUEST_ANIMATION_FRAME=1) {
> +    !v8 {
> +        SOURCES += \
> +            bindings/js/JSRequestAnimationFrameCallbackCustom.cpp
> +    }
> +
> +    SOURCES += \
> +        dom/ScriptedAnimationController.cpp
> +
> +    HEADERS += \
> +        dom/ScriptedAnimationController.h
> +}

I believe that you can add these files to the build unconditionally. They follow the common WebKit pattern that all files are buildable and contain corresponding preprocessor guards. The files in question here appear to contain them, so they will compile with and without the feature enabled.

So AFAICS we don't _need_ to make Target.pri more complex :)

[Igor Trindade Oliveira]

Created attachment 119421 [details]
Patch v2

proposed patch.

[WebKit Review Bot]

Comment on attachment 119421 [details]
Patch v2

Clearing flags on attachment: 119421

Committed r102939: <http://trac.webkit.org/changeset/102939>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

Reopen, because tests still fail:

+CONSOLE MESSAGE: line 7: TypeError: 'undefined' is not a function (evaluating 'window.webkitRequestAnimationFrame(function()

I think you should have run layout tests before unsipping them ...

[Igor Trindade Oliveira]

It was working, but now after rebase webkit, it is failing.
I am investigating the problem.

(In reply to comment #7)
> Reopen, because tests still fail:
> 
> +CONSOLE MESSAGE: line 7: TypeError: 'undefined' is not a function (evaluating 'window.webkitRequestAnimationFrame(function()
> 
> I think you should have run layout tests before unsipping them ...

[Igor Trindade Oliveira]

The bot needs to clean up the QtWebKit build. It needs to regenerate JSDOMWindow.* files.

(In reply to comment #7)
> Reopen, because tests still fail:
> 
> +CONSOLE MESSAGE: line 7: TypeError: 'undefined' is not a function (evaluating 'window.webkitRequestAnimationFrame(function()
> 
> I think you should have run layout tests before unsipping them ...

[Tor Arne Vestbø]

(In reply to comment #9)
> The bot needs to clean up the QtWebKit build. It needs to regenerate JSDOMWindow.* files.
> 
> (In reply to comment #7)
> > Reopen, because tests still fail:
> > 
> > +CONSOLE MESSAGE: line 7: TypeError: 'undefined' is not a function (evaluating 'window.webkitRequestAnimationFrame(function()
> > 
> > I think you should have run layout tests before unsipping them ...

This is a limitation of the clean-check in build-webkit. It only detects changed or removed, not added defines. I'll have a look.

[Csaba Osztrogonác]

(In reply to comment #10)
> (In reply to comment #9)
> > The bot needs to clean up the QtWebKit build. It needs to regenerate JSDOMWindow.* files.
> > 
> > (In reply to comment #7)
> > > Reopen, because tests still fail:
> > > 
> > > +CONSOLE MESSAGE: line 7: TypeError: 'undefined' is not a function (evaluating 'window.webkitRequestAnimationFrame(function()
> > > 
> > > I think you should have run layout tests before unsipping them ...
> 
> This is a limitation of the clean-check in build-webkit. It only detects changed or removed, not added defines. I'll have a look.

Ah, one more build system related bug. Good to know. Sorry for the invalid suspection. :) Hmmm ... maybe it caused problems near the webkit_testfonts patch. (It added HAVE_FONTCONFIG)

[Csaba Osztrogonác]

I file a new bug report: https://bugs.webkit.org/show_bug.cgi?id=74689

[Simon Hausmann]

With this feature landed fast/animation/request-animation-frame-during-modal.html fails permanently, due to the lack of modal dialog support.

See also http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20WebKit2

[Simon Hausmann]

(In reply to comment #13)
> With this feature landed fast/animation/request-animation-frame-during-modal.html fails permanently, due to the lack of modal dialog support.
> 
> See also http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20WebKit2

I've created bug #74852 to fix this. Working on it atm