Bug 74852 - [Qt][WK2] Add support for modal event loop processing for WTR
Summary: [Qt][WK2] Add support for modal event loop processing for WTR
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Hausmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-19 03:50 PST by Simon Hausmann
Modified: 2012-11-12 02:45 PST (History)
3 users (show)

See Also:


Attachments
Patch (8.03 KB, patch)
2011-12-19 04:00 PST, Simon Hausmann
no flags Details | Formatted Diff | Diff
Patch (8.18 KB, patch)
2011-12-19 04:08 PST, Simon Hausmann
no flags Details | Formatted Diff | Diff
Patch (4.98 KB, patch)
2012-11-09 08:57 PST, Balazs Kelemen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2011-12-19 03:50:05 PST
[Qt][WK2] Add support for modal event loop processing for WTR
Comment 1 Simon Hausmann 2011-12-19 03:52:10 PST
Lack of support causes fast/animation/request-animation-frame-during-modal.html to fail with Qt/WK2 right now
Comment 2 Simon Hausmann 2011-12-19 04:00:02 PST
Created attachment 119844 [details]
Patch
Comment 3 Simon Hausmann 2011-12-19 04:08:42 PST
Created attachment 119845 [details]
Patch

Updated patch that fixes build issue with moc file inclusion
Comment 4 Kenneth Rohde Christiansen 2011-12-19 04:14:01 PST
Comment on attachment 119845 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119845&action=review

> Source/WebKit2/Platform/qt/RunLoopQt.cpp:65
> +    static bool mainEventLoopRunning = false;

IsRunning?

> Source/WebKit2/Platform/qt/RunLoopQt.cpp:73
> +        QEventLoop* oldCurrent = currentEventLoop;

old current sounds strange
Comment 5 Simon Hausmann 2011-12-19 04:23:26 PST
Comment on attachment 119845 [details]
Patch

Thanks for the review. Will rename the variables before landing.
Comment 6 Simon Hausmann 2011-12-19 04:34:23 PST
Committed r103228: <http://trac.webkit.org/changeset/103228>
Comment 7 Balazs Kelemen 2012-11-09 08:57:28 PST
Reopening to attach new patch.
Comment 8 Balazs Kelemen 2012-11-09 08:57:31 PST
Created attachment 173316 [details]
Patch
Comment 9 Balazs Kelemen 2012-11-12 02:45:46 PST
Comment on attachment 173316 [details]
Patch

Oops, sorry, wrong bug.