Bug 74475 - [Blackberry] Switch to libjpeg for decoding
Summary: [Blackberry] Switch to libjpeg for decoding
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-13 18:29 PST by Jacky Jiang
Modified: 2011-12-14 01:12 PST (History)
9 users (show)

See Also:


Attachments
Patch (4.84 KB, patch)
2011-12-13 20:36 PST, Jacky Jiang
no flags Details | Formatted Diff | Diff
Patch (4.51 KB, patch)
2011-12-13 22:57 PST, Jacky Jiang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jacky Jiang 2011-12-13 18:29:33 PST
Switch to libjpeg and use WebCore cross platform JPEG decoder for decoding.
PR #88341.
Comment 1 Jacky Jiang 2011-12-13 20:36:15 PST
Created attachment 119148 [details]
Patch
Comment 2 Antonio Gomes 2011-12-13 21:27:18 PST
Comment on attachment 119148 [details]
Patch

yay!
Comment 3 Jacky Jiang 2011-12-13 21:38:56 PST
Comment on attachment 119148 [details]
Patch

Should I cq+ this or need your cq+ Antonio?
Comment 4 Daniel Bates 2011-12-13 22:20:56 PST
Comment on attachment 119148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119148&action=review

> Source/WebCore/PlatformBlackBerry.cmake:-178
> -    platform/image-decoders/bmp/BMPImageDecoder.cpp
> -    platform/image-decoders/gif/GIFImageDecoder.cpp
> -    platform/image-decoders/ico/ICOImageDecoder.cpp
> -    platform/image-decoders/png/PNGImageDecoder.cpp

Can you elaborate on how you came to the decision to remove these entries in this patch? I mean, this patch is about the JPEG image decoder. I suggest that we remove these entries in a separate bug.
Comment 5 Jacky Jiang 2011-12-13 22:27:02 PST
Comment on attachment 119148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119148&action=review

>> Source/WebCore/PlatformBlackBerry.cmake:-178
>> -    platform/image-decoders/png/PNGImageDecoder.cpp
> 
> Can you elaborate on how you came to the decision to remove these entries in this patch? I mean, this patch is about the JPEG image decoder. I suggest that we remove these entries in a separate bug.

Ok, I will update this patch and remove these entries in a separate bug then, thanks!
Comment 6 Jacky Jiang 2011-12-13 22:57:35 PST
Created attachment 119159 [details]
Patch

Update the patch according to Dan's comments.
Comment 7 Daniel Bates 2011-12-13 23:02:02 PST
Comment on attachment 119159 [details]
Patch

Thanks Jacky for updating the patch.
Comment 8 Jacky Jiang 2011-12-13 23:08:10 PST
(In reply to comment #7)
> (From update of attachment 119159 [details])
> Thanks Jacky for updating the patch.
No problem, thank you for the review.
Remove entries will be fixed here :
https://bugs.webkit.org/show_bug.cgi?id=74484
Comment 9 WebKit Review Bot 2011-12-14 01:12:23 PST
Comment on attachment 119159 [details]
Patch

Clearing flags on attachment: 119159

Committed r102750: <http://trac.webkit.org/changeset/102750>
Comment 10 WebKit Review Bot 2011-12-14 01:12:28 PST
All reviewed patches have been landed.  Closing bug.