Bug 74475 – [Blackberry] Switch to libjpeg for decoding

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Jacky Jiang]

Switch to libjpeg and use WebCore cross platform JPEG decoder for decoding.
PR #88341.

[Jacky Jiang]

Created attachment 119148 [details]
Patch

[Antonio Gomes]

Comment on attachment 119148 [details]
Patch

yay!

[Jacky Jiang]

Comment on attachment 119148 [details]
Patch

Should I cq+ this or need your cq+ Antonio?

[Daniel Bates]

Comment on attachment 119148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119148&action=review

> Source/WebCore/PlatformBlackBerry.cmake:-178
> -    platform/image-decoders/bmp/BMPImageDecoder.cpp
> -    platform/image-decoders/gif/GIFImageDecoder.cpp
> -    platform/image-decoders/ico/ICOImageDecoder.cpp
> -    platform/image-decoders/png/PNGImageDecoder.cpp

Can you elaborate on how you came to the decision to remove these entries in this patch? I mean, this patch is about the JPEG image decoder. I suggest that we remove these entries in a separate bug.

[Jacky Jiang]

Comment on attachment 119148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=119148&action=review

>> Source/WebCore/PlatformBlackBerry.cmake:-178
>> -    platform/image-decoders/png/PNGImageDecoder.cpp
> 
> Can you elaborate on how you came to the decision to remove these entries in this patch? I mean, this patch is about the JPEG image decoder. I suggest that we remove these entries in a separate bug.

Ok, I will update this patch and remove these entries in a separate bug then, thanks!

[Jacky Jiang]

Created attachment 119159 [details]
Patch

Update the patch according to Dan's comments.

[Daniel Bates]

Comment on attachment 119159 [details]
Patch

Thanks Jacky for updating the patch.

[Jacky Jiang]

(In reply to comment #7)
> (From update of attachment 119159 [details])
> Thanks Jacky for updating the patch.
No problem, thank you for the review.
Remove entries will be fixed here :
https://bugs.webkit.org/show_bug.cgi?id=74484

[WebKit Review Bot]

Comment on attachment 119159 [details]
Patch

Clearing flags on attachment: 119159

Committed r102750: <http://trac.webkit.org/changeset/102750>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.