Bug 74414 - [Qt][WK2] Remove DrawingArea and QtWebPageEventHandler code from QtWebPageProxy
Summary: [Qt][WK2] Remove DrawingArea and QtWebPageEventHandler code from QtWebPageProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Marcelo de Oliveira Filho
URL:
Keywords:
Depends on:
Blocks: 72943
  Show dependency tree / graph
 
Reported: 2011-12-13 09:00 PST by Caio Marcelo de Oliveira Filho
Modified: 2011-12-14 04:50 PST (History)
2 users (show)

See Also:

Attachments
Patch (20.43 KB, patch)
2011-12-13 09:02 PST, Caio Marcelo de Oliveira Filho 		no flags Details | Formatted Diff | Diff
Patch (26.59 KB, patch)
2011-12-13 10:07 PST, Caio Marcelo de Oliveira Filho 		no flags Details | Formatted Diff | Diff
Patch (26.66 KB, patch)
2011-12-13 10:55 PST, Caio Marcelo de Oliveira Filho 		hausmann: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Marcelo de Oliveira Filho 2011-12-13 09:00:15 PST 
[Qt][WK2] Remove DrawingArea and QtWebPageEventHandler code from QtWebPageProxy
Comment 1 Caio Marcelo de Oliveira Filho 2011-12-13 09:02:04 PST 
Created attachment 119026 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2011-12-13 09:06:42 PST 
Comment on attachment 119026 [details]
Patch

r=me, some things could be better as discussed on irc... but bady steps :)
Comment 3 Caio Marcelo de Oliveira Filho 2011-12-13 10:07:10 PST 
Created attachment 119031 [details]
Patch
Comment 4 Caio Marcelo de Oliveira Filho 2011-12-13 10:25:09 PST 
(In reply to comment #2)
> (From update of attachment 119026 [details])
> r=me, some things could be better as discussed on irc... but bady steps :)

Kenneth, I have changed a bit, and I've moved the event handler into the quickwebpage. This way quickwebpage doesn't need to be aware of quickwebview. I think it is a bit better. Can you look at this new patch? :-)
Comment 5 Caio Marcelo de Oliveira Filho 2011-12-13 10:55:31 PST 
Created attachment 119040 [details]
Patch
Comment 6 Caio Marcelo de Oliveira Filho 2011-12-14 04:50:32 PST 
Committed r102765: <http://trac.webkit.org/changeset/102765>