Bug 74357 - [chromium] Need expectations for plugins/netscape-plugin-page-cache-works.html
Summary: [chromium] Need expectations for plugins/netscape-plugin-page-cache-works.html
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 13634
Blocks:
  Show dependency tree / graph
 
Reported: 2011-12-12 15:14 PST by Kenneth Russell
Modified: 2013-04-09 16:28 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2011-12-12 15:14:44 PST 
http://trac.webkit.org/changeset/102619 introduced layout test plugins/netscape-plugin-page-cache-works.html which needs Chromium expectations.

Suppressing the failure for the moment.
Comment 1 Kenneth Russell 2011-12-12 15:19:28 PST 
Suppressed in http://trac.webkit.org/changeset/102630 .
Comment 2 Kenneth Russell 2011-12-12 15:52:11 PST 
This may be involved; making Chromium obey the layout test controller key WebKitPageCacheSupportsPluginsPreferenceKey is also needed.
Comment 3 Brady Eidson 2011-12-12 16:04:35 PST 
(In reply to comment #2)
> This may be involved; making Chromium obey the layout test controller key WebKitPageCacheSupportsPluginsPreferenceKey is also needed.

AFAIK, Chromium has never supported the WebCore page cache...  just as an FYI.

I would be surprised to hear if you planned to; Please comment if that's the case...
Comment 4 Kenneth Russell 2011-12-12 16:50:40 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > This may be involved; making Chromium obey the layout test controller key WebKitPageCacheSupportsPluginsPreferenceKey is also needed.
> 
> AFAIK, Chromium has never supported the WebCore page cache...  just as an FYI.
> 
> I would be surprised to hear if you planned to; Please comment if that's the case...

You're right, it looks like Chromium does not use WebCore's page cache by default, though it can be enabled via a command line option.

However, Chromium's LayoutTestController does support the WebKitUsesPageCachePreferenceKey, so it seems that it should also support WebKitPageCacheSupportsPluginsPreferenceKey.
Comment 5 Kenneth Russell 2011-12-12 17:50:00 PST 
Expanded the suppression in http://trac.webkit.org/changeset/102647 .

For the record, I tried implementing the obvious DumpRenderTree support for the new flag, but the test still fails. It looks like the test page doesn't navigate back properly.
Comment 6 Kenneth Russell 2011-12-13 15:20:46 PST 
Unfortunately it looks like the test timeout may be causing other tests in the shard to fail. Actually skipped the test in http://trac.webkit.org/changeset/102654 .
Comment 7 Stephen Chenney 2013-04-09 16:28:29 PDT 
Marking test failures as WontFix. Bug is still accessible and recording in TestExpectations.