RESOLVED FIXED 74301
[EFL] Add API to notify that mixed content has been loaded. 
https://bugs.webkit.org/show_bug.cgi?id=74301
Summary [EFL] Add API to notify that mixed content has been loaded.
Raphael Kubo da Costa (:rakuco)
Reported 2011-12-12 08:41:46 PST
[EFL] Add API to notify that mixed content has been loaded.
Attachments
Patch (14.79 KB, patch)
2011-12-12 08:42 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Patch with bug number (14.79 KB, patch)
2011-12-12 08:48 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Move DocumentLoader.h include to bug 74302 (14.61 KB, patch)
2011-12-12 09:01 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Patch for landing, follow kov's suggestion (14.61 KB, patch)
2011-12-12 09:28 PST, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2011-12-12 08:42:10 PST
Created attachment 118795 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2011-12-12 08:48:02 PST
Created attachment 118799 [details] Patch with bug number
Raphael Kubo da Costa (:rakuco)
Comment 3 2011-12-12 09:01:18 PST
Created attachment 118805 [details] Move DocumentLoader.h include to bug 74302
Gustavo Noronha (kov)
Comment 4 2011-12-12 09:20:17 PST
Comment on attachment 118805 [details] Move DocumentLoader.h include to bug 74302 View in context: https://bugs.webkit.org/attachment.cgi?id=118805&action=review OK, looks good, with just a nit. > Source/WebKit/efl/ewk/ewk_frame.cpp:1706 > + evas_object_smart_callback_call(ewkFrame, "mixedcontent,displayed", 0); > + ewk_view_mixed_content_displayed_set(smartData->view, true); Wouldn't it be more conceptually correct to first set it, and then emit the signal? This way if the API user for some bizarre reason decides to query this flag while handling the signal it'll be properly set.
Raphael Kubo da Costa (:rakuco)
Comment 5 2011-12-12 09:28:20 PST
Created attachment 118810 [details] Patch for landing, follow kov's suggestion
Raphael Kubo da Costa (:rakuco)
Comment 6 2011-12-12 10:21:05 PST
Committed r102600: <http://trac.webkit.org/changeset/102600>
Note You need to log in before you can comment on or make changes to this bug.