Bug 74302 - [EFL] Add API to query the validity of a frame's SSL certificate.
Summary: [EFL] Add API to query the validity of a frame's SSL certificate.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-12 08:43 PST by Raphael Kubo da Costa (:rakuco)
Modified: 2011-12-12 10:21 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.85 KB, patch)
2011-12-12 08:43 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff
Patch with bug number (3.85 KB, patch)
2011-12-12 08:48 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff
Patch for landing. Move DocumentLoader.h include from bug 74301 (4.03 KB, patch)
2011-12-12 09:03 PST, Raphael Kubo da Costa (:rakuco)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2011-12-12 08:43:00 PST
[EFL] Add API to query the validity of a frame's SSL certificate.
Comment 1 Raphael Kubo da Costa (:rakuco) 2011-12-12 08:43:26 PST
Created attachment 118796 [details]
Patch
Comment 2 WebKit Review Bot 2011-12-12 08:46:50 PST
Attachment 118796 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1

Source/WebKit/efl/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Raphael Kubo da Costa (:rakuco) 2011-12-12 08:48:33 PST
Created attachment 118800 [details]
Patch with bug number
Comment 4 Gyuyoung Kim 2011-12-12 08:57:09 PST
Comment on attachment 118800 [details]
Patch with bug number

Attachment 118800 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10841155
Comment 5 Gustavo Noronha (kov) 2011-12-12 09:01:07 PST
Comment on attachment 118800 [details]
Patch with bug number

Looks correct to me. And looks like you're missing #include "DocumentLoader.h"; I guess you can fix that when landing.
Comment 6 Raphael Kubo da Costa (:rakuco) 2011-12-12 09:03:01 PST
Created attachment 118806 [details]
Patch for landing. Move DocumentLoader.h include from bug 74301
Comment 7 Raphael Kubo da Costa (:rakuco) 2011-12-12 10:21:35 PST
Committed r102601: <http://trac.webkit.org/changeset/102601>