Bug 73879 - Revert WebCore track settings changes made in r101977
Summary: Revert WebCore track settings changes made in r101977
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks: 43668
  Show dependency tree / graph
 
Reported: 2011-12-05 17:15 PST by Eric Carlson
Modified: 2011-12-06 11:01 PST (History)
2 users (show)

See Also:

Attachments
Proposed patch (2.57 KB, patch)
2011-12-05 17:28 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2011-12-05 17:15:13 PST 
From https://bugs.webkit.org/show_bug.cgi?id=73721:

> Source/WebCore/page/Settings.cpp:854
> +#if ENABLE(VIDEO_TRACK)
> +void Settings::setShouldDisplaySubtitles(bool flag)
> +{
> +    m_shouldDisplaySubtitles = flag;
> +}
> +
> +void Settings::setShouldDisplayCaptions(bool flag)
> +{
> +    m_shouldDisplayCaptions = flag;
> +}
> +
> +void Settings::setShouldDisplayTextDescriptions(bool flag)
> +{
> +    m_shouldDisplayTextDescriptions = flag;
> +}
> +#endif

Why this change? You moved these into the cpp file, but they are the same as what was in the .h file?
Comment 1 Radar WebKit Bug Importer 2011-12-05 17:15:53 PST 
<rdar://problem/10531518>
Comment 2 Eric Carlson 2011-12-05 17:28:29 PST 
Created attachment 117960 [details]
Proposed patch
Comment 3 WebKit Review Bot 2011-12-06 11:01:39 PST 
Comment on attachment 117960 [details]
Proposed patch

Clearing flags on attachment: 117960

Committed r102154: <http://trac.webkit.org/changeset/102154>
Comment 4 WebKit Review Bot 2011-12-06 11:01:43 PST 
All reviewed patches have been landed.  Closing bug.