Bug 73837 – Reland chromium event dispatch test from https://bugs.webkit.org/show_bug.cgi?id=72988

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dave Michael]

Reland chromium event dispatch test from https://bugs.webkit.org/show_bug.cgi?id=72988

[Dave Michael]

Created attachment 117890 [details]
Patch

[Dave Michael]

Comment on attachment 117890 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117890&action=review

> Source/WebKit/chromium/tests/DispatchEventTest.cpp:82
> +        m_targetParent = m_document.getElementById("target_parent");

This is the only line that changed from https://bugs.webkit.org/show_bug.cgi?id=72988. It used to say 'targetParent', which didn't match the HTML file. I must've changed one and not the other, and failed to rerun locally assuming the chromium unit tests got run on the WebKit bots.

[Hajime Morrita]

Comment on attachment 117890 [details]
Patch

Looks sane and the impact should be Chromium local. r+ing.

[WebKit Review Bot]

Comment on attachment 117890 [details]
Patch

Rejecting attachment 117890 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 *** Waiting for unfinished jobs....
  LINK(target) out/Debug/TestWebKitAPI: Finished

Failed to run "['Tools/Scripts/build-webkit', '--debug', '--chromium', '--update-chromium']" exit_code: 2
ventTest.cpp:40: fatal error: WebSerializedScriptValue.h: No such file or directory
compilation terminated.
make: *** [out/Debug/obj.target/webkit_unit_tests/Source/WebKit/chromium/tests/DispatchEventTest.o] Error 1
make: *** Waiting for unfinished jobs....
  LINK(target) out/Debug/TestWebKitAPI: Finished

Full output: http://queues.webkit.org/results/10825969

[WebKit Review Bot]

Comment on attachment 117890 [details]
Patch

Rejecting attachment 117890 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
hing file Source/WebKit/chromium/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/chromium/WebKit.gypi
Hunk #1 FAILED at 69.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/WebKit.gypi.rej
patching file Source/WebKit/chromium/tests/DispatchEventTest.cpp
patching file Source/WebKit/chromium/tests/data/event_target.html

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Hajime Morita', u'--fo..." exit_code: 1

Full output: http://queues.webkit.org/results/10981244

[Dave Michael]

Created attachment 120959 [details]
Patch

[Dave Michael]

Comment on attachment 120959 [details]
Patch

Sorry for the out-dated patch. I just updated, and this one should be ready to land again.

[WebKit Review Bot]

Comment on attachment 120959 [details]
Patch

Clearing flags on attachment: 120959

Committed r105040: <http://trac.webkit.org/changeset/105040>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.