Bug 72988 - Chromium API for creating and dispatching events has no unit tests
Summary: Chromium API for creating and dispatching events has no unit tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Michael
URL:
Keywords:
Depends on: 73736
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-22 15:45 PST by Dave Michael
Modified: 2011-12-02 22:51 PST (History)
3 users (show)

See Also:


Attachments
Patch (5.88 KB, patch)
2011-11-22 15:46 PST, Dave Michael
no flags Details | Formatted Diff | Diff
Patch (8.21 KB, patch)
2011-11-23 13:51 PST, Dave Michael
no flags Details | Formatted Diff | Diff
Patch (8.24 KB, patch)
2011-11-23 13:54 PST, Dave Michael
no flags Details | Formatted Diff | Diff
Patch (8.18 KB, patch)
2011-12-02 14:36 PST, Dave Michael
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Michael 2011-11-22 15:45:32 PST
Chromium API for creating and dispatching events has no unit tests
Comment 1 Dave Michael 2011-11-22 15:46:07 PST
Created attachment 116283 [details]
Patch
Comment 2 Dave Michael 2011-11-23 13:51:06 PST
Created attachment 116417 [details]
Patch
Comment 3 Dave Michael 2011-11-23 13:54:48 PST
Created attachment 116419 [details]
Patch
Comment 4 Dave Michael 2011-11-23 14:05:11 PST
Comment on attachment 116419 [details]
Patch

Here's the test I promised for https://bugs.webkit.org/show_bug.cgi?id=71478
Comment 5 WebKit Review Bot 2011-12-02 14:23:48 PST
Comment on attachment 116419 [details]
Patch

Rejecting attachment 116419 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
hing file Source/WebKit/chromium/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/chromium/WebKit.gypi
Hunk #1 FAILED at 66.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/WebKit.gypi.rej
patching file Source/WebKit/chromium/tests/DispatchEventTest.cpp
patching file Source/WebKit/chromium/tests/data/event_target.html

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Darin Fisher', u'--for..." exit_code: 1

Full output: http://queues.webkit.org/results/10701418
Comment 6 Dave Michael 2011-12-02 14:36:55 PST
Created attachment 117693 [details]
Patch
Comment 7 Dave Michael 2011-12-02 14:37:38 PST
Comment on attachment 117693 [details]
Patch

Sorry for the trouble; the old patch was quite old. This is just a merge.
Comment 8 WebKit Review Bot 2011-12-02 21:56:46 PST
Comment on attachment 117693 [details]
Patch

Clearing flags on attachment: 117693

Committed r101906: <http://trac.webkit.org/changeset/101906>
Comment 9 WebKit Review Bot 2011-12-02 21:56:50 PST
All reviewed patches have been landed.  Closing bug.