Bug 71478 - Fix up chromium API for creating events, initializing message events
Summary: Fix up chromium API for creating events, initializing message events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-03 09:19 PDT by Dave Michael
Modified: 2011-11-16 13:14 PST (History)
2 users (show)

See Also:


Attachments
Patch (3.86 KB, patch)
2011-11-03 09:33 PDT, Dave Michael
no flags Details | Formatted Diff | Diff
Patch (3.89 KB, patch)
2011-11-04 07:48 PDT, Dave Michael
no flags Details | Formatted Diff | Diff
Patch (3.92 KB, patch)
2011-11-15 13:26 PST, Dave Michael
no flags Details | Formatted Diff | Diff
Patch (3.93 KB, patch)
2011-11-16 09:26 PST, Dave Michael
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Michael 2011-11-03 09:19:25 PDT
Fix up chromium API for creating events, initializing message events
Comment 1 Dave Michael 2011-11-03 09:33:45 PDT
Created attachment 113506 [details]
Patch
Comment 2 Dave Michael 2011-11-03 09:35:20 PDT
Comment on attachment 113506 [details]
Patch

Note: initMessageEvent is not used yet in Chromium, so it's safe to change until the referenced Chromium CL lands.
Comment 3 WebKit Review Bot 2011-11-03 09:35:39 PDT
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 4 Darin Fisher (:fishd, Google) 2011-11-03 22:36:17 PDT
Comment on attachment 113506 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113506&action=review

> Source/WebKit/chromium/src/WebDOMMessageEvent.cpp:58
> +        static_cast<const WebFrameImpl*>(sourceFrame)->frame()->domWindow();

don't you need to assign domWindow() to 'window' ?
Comment 5 Dave Michael 2011-11-04 07:48:57 PDT
Created attachment 113657 [details]
Patch
Comment 6 Dave Michael 2011-11-04 07:50:19 PDT
(In reply to comment #4)
> (From update of attachment 113506 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113506&action=review
> 
> > Source/WebKit/chromium/src/WebDOMMessageEvent.cpp:58
> > +        static_cast<const WebFrameImpl*>(sourceFrame)->frame()->domWindow();
> 
> don't you need to assign domWindow() to 'window' ?
Definitely. Nice catch. Speaking of, is there a good place to add a unit test for this? Should I do that, or does the ui_test in chromium (which doesn't cover this code path right now) suffice?
Comment 7 Dave Michael 2011-11-15 13:26:11 PST
Created attachment 115228 [details]
Patch
Comment 8 Dave Michael 2011-11-15 13:26:56 PST
Comment on attachment 115228 [details]
Patch

Merged. PTAL.
Comment 9 Darin Fisher (:fishd, Google) 2011-11-16 09:19:05 PST
Comment on attachment 115228 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115228&action=review

> Source/WebKit/chromium/ChangeLog:6
> +- Fix a mistake when checking the exception code during event creation.

nit: fix indentation here

> Source/WebKit/chromium/src/WebDOMMessageEvent.cpp:58
> +        window =

nit: webkit style does not enforce line length limits, so this should just be on one line.
Comment 10 Dave Michael 2011-11-16 09:26:56 PST
Created attachment 115393 [details]
Patch
Comment 11 WebKit Review Bot 2011-11-16 13:14:33 PST
Comment on attachment 115393 [details]
Patch

Clearing flags on attachment: 115393

Committed r100497: <http://trac.webkit.org/changeset/100497>
Comment 12 WebKit Review Bot 2011-11-16 13:14:37 PST
All reviewed patches have been landed.  Closing bug.