Bug 73631 - [chromium] Add layout test support for autosize code in FrameView.
Summary: [chromium] Add layout test support for autosize code in FrameView.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on: 73058 73420
Blocks: 73035
  Show dependency tree / graph
 
Reported: 2011-12-01 23:45 PST by David Levin
Modified: 2012-01-08 00:06 PST (History)
2 users (show)

See Also:

Attachments
Patch (12.83 KB, patch)
2012-01-06 13:49 PST, David Levin 		no flags Details | Formatted Diff | Diff
Patch for landing (12.88 KB, patch)
2012-01-06 14:23 PST, David Levin 		no flags Details | Formatted Diff | Diff
Patch for landing (12.90 KB, patch)
2012-01-07 22:59 PST, David Levin 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2011-12-01 23:45:11 PST 
Only chromium because that is the only place where I'm exposing a WebKit api for this.
Comment 1 David Levin 2011-12-01 23:49:31 PST 
And add tests using that support of course.
Comment 2 David Levin 2012-01-06 13:49:18 PST 
Created attachment 121485 [details]
Patch
Comment 3 Dmitry Titov 2012-01-06 14:03:25 PST 
Comment on attachment 121485 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=121485&action=review

r+ with a nit. If there will be more tests in this dir, lets share things like shouldBe() between them.

> Tools/DumpRenderTree/chromium/LayoutTestController.cpp:1107
> +        return;

result->set(false); ?
Comment 4 David Levin 2012-01-06 14:23:51 PST 
Created attachment 121496 [details]
Patch for landing
Comment 5 WebKit Review Bot 2012-01-06 18:29:08 PST 
Comment on attachment 121496 [details]
Patch for landing

Rejecting attachment 121496 [details] from commit-queue.

New failing tests:
fast/autoresize/basic.html
Full output: http://queues.webkit.org/results/11171171
Comment 6 David Levin 2012-01-07 22:59:36 PST 
Created attachment 121568 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-01-08 00:06:54 PST 
Comment on attachment 121568 [details]
Patch for landing

Clearing flags on attachment: 121568

Committed r104398: <http://trac.webkit.org/changeset/104398>
Comment 8 WebKit Review Bot 2012-01-08 00:06:59 PST 
All reviewed patches have been landed.  Closing bug.