Bug 73420 - Add a way to automatically size a single frame to fit its content.
: Add a way to automatically size a single frame to fit its content.
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: David Levin
:
Depends on:
Blocks: 73035 73058 73631
  Show dependency treegraph
 
Reported: 2011-11-30 02:56 PST by David Levin
Modified: 2011-12-01 23:49 PST (History)
2 users (show)

See Also:


Attachments
WIP (8.45 KB, patch)
2011-11-30 03:00 PST, David Levin
no flags Details | Formatted Diff | Diff
Patch (8.13 KB, patch)
2011-12-01 13:31 PST, David Levin
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-01 (347.13 KB, application/zip)
2011-12-01 14:50 PST, WebKit Review Bot
no flags Details
Patch (7.75 KB, patch)
2011-12-01 16:26 PST, David Levin
dimich: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2011-11-30 02:56:32 PST
See summary.
Comment 1 David Levin 2011-11-30 03:00:08 PST
Created attachment 117156 [details]
WIP
Comment 2 Alexey Proskuryakov 2011-11-30 11:35:34 PST
Comment on attachment 117156 [details]
WIP

Does this need to be ifdefed? The cost of breaking builds due to code that isn't enabled on contributor's platform is fairly high.
Comment 3 David Levin 2011-11-30 11:37:08 PST
(In reply to comment #2)
> (From update of attachment 117156 [details])
> Does this need to be ifdefed? The cost of breaking builds due to code that isn't enabled on contributor's platform is fairly high.

No worries, I'll get rid of that.
Comment 4 David Levin 2011-12-01 13:31:03 PST
Created attachment 117476 [details]
Patch
Comment 5 WebKit Review Bot 2011-12-01 14:50:02 PST
Comment on attachment 117476 [details]
Patch

Attachment 117476 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10704764

New failing tests:
compositing/generated-content.html
compositing/scrollbar-painting.html
compositing/geometry/clip.html
compositing/geometry/foreground-layer.html
compositing/geometry/limit-layer-bounds-overflow-repaint.html
compositing/geometry/layer-due-to-layer-children.html
compositing/geometry/composited-html-size.html
compositing/geometry/limit-layer-bounds-positioned-transition.html
compositing/animation/state-at-end-event-transform-layer.html
compositing/backface-visibility.html
compositing/geometry/clipped-video-controller.html
compositing/geometry/ancestor-overflow-change.html
compositing/geometry/layer-due-to-layer-children-deep.html
compositing/color-matching/image-color-matching.html
compositing/geometry/fixed-position.html
animations/3d/change-transform-in-end-event.html
animations/3d/state-at-end-event-transform.html
animations/opacity-transform-animation.html
compositing/backface-visibility-hierarchical-transform.html
compositing/animation/busy-indicator.html
Comment 6 WebKit Review Bot 2011-12-01 14:50:06 PST
Created attachment 117494 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 7 David Levin 2011-12-01 16:26:42 PST
Created attachment 117517 [details]
Patch
Comment 8 Dmitry Titov 2011-12-01 17:44:07 PST
Comment on attachment 117517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117517&action=review

> Source/WebCore/ChangeLog:8
> +        No new functionality exposed so no new tests. (There is a Chromium

It might be a separate patch, but it seems having it exposed at least via Chromium API and in Chromium DRT is what we want to do in order to add more tests. This will need more tests.

> Source/WebCore/page/FrameView.cpp:2331
> +        // Increase the dimensions due to any scrollbars that are displayed.

The comment should be updated to reflect the fact that these address situation when only one of the dimensions is over the limit - because if both are inside the limit there is no scrolbars and if both are outside the limit - then the limit already took care of both.
Comment 9 David Levin 2011-12-01 23:49:48 PST
Committed as http://trac.webkit.org/changeset/101752.

(In reply to comment #8)
> (From update of attachment 117517 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117517&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new functionality exposed so no new tests. (There is a Chromium
> 
> It might be a separate patch, but it seems having it exposed at least via Chromium API and in Chromium DRT is what we want to do in order to add more tests. This will need more tests.

Filed bug 73631.

> 
> > Source/WebCore/page/FrameView.cpp:2331
> > +        // Increase the dimensions due to any scrollbars that are displayed.
> 
> The comment should be updated to reflect the fact that these address situation when only one of the dimensions is over the limit - because if both are inside the limit there is no scrolbars and if both are outside the limit - then the limit already took care of both.

Done.