Bug 73375 – Resetting a put_by_id inline cache should preserve the "isDirect" bit

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Currently when a put_by_id inline cache is reset, we forget if it was direct.

[Filip Pizlo]

<rdar://problem/10500875>

[Filip Pizlo]

Created attachment 117075 [details]
the patch

[WebKit Review Bot]

Attachment 117075 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/jit/JITPropertyAccess.cpp:1160:  Declaration has space between type name and * in void *oldCall  [whitespace/declaration] [3]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/101457

[Filip Pizlo]

(In reply to comment #3)
> Attachment 117075 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
> 
> Source/JavaScriptCore/jit/JITPropertyAccess.cpp:1160:  Declaration has space between type name and * in void *oldCall  [whitespace/declaration] [3]
> Total errors found: 1 in 10 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Ooops!  I addressed this in the code that I committed.

[Filip Pizlo]

Comment on attachment 117075 [details]
the patch

Clearing flags after landing.

[Csaba Osztrogonác]

It broke the Qt ARM build:

../../../../Source/JavaScriptCore/jit/JITPropertyAccess.cpp: In static member function 'static bool JSC::JIT::isDirectPutById(JSC::StructureStubInfo*)':
../../../../Source/JavaScriptCore/jit/JITPropertyAccess.cpp:1160: error: 'readCallTarget' is not a member of 'JSC::MacroAssembler'

[Filip Pizlo]

(In reply to comment #7)
> It broke the Qt ARM build:
> 
> ../../../../Source/JavaScriptCore/jit/JITPropertyAccess.cpp: In static member function 'static bool JSC::JIT::isDirectPutById(JSC::StructureStubInfo*)':
> ../../../../Source/JavaScriptCore/jit/JITPropertyAccess.cpp:1160: error: 'readCallTarget' is not a member of 'JSC::MacroAssembler'

ARMv6 or ARMv7?

[Filip Pizlo]

(In reply to comment #8)
> (In reply to comment #7)
> > It broke the Qt ARM build:
> > 
> > ../../../../Source/JavaScriptCore/jit/JITPropertyAccess.cpp: In static member function 'static bool JSC::JIT::isDirectPutById(JSC::StructureStubInfo*)':
> > ../../../../Source/JavaScriptCore/jit/JITPropertyAccess.cpp:1160: error: 'readCallTarget' is not a member of 'JSC::MacroAssembler'
> 
> ARMv6 or ARMv7?

Proposed patch for ARMv6 here: https://bugs.webkit.org/show_bug.cgi?id=73413