Bug 73413 - MacroAssemblerARM does not implement readCallTarget
Summary: MacroAssemblerARM does not implement readCallTarget
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-30 01:42 PST by Filip Pizlo
Modified: 2011-11-30 11:09 PST (History)
3 users (show)

See Also:

Attachments
the patch (1.83 KB, patch)
2011-11-30 01:43 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
Patch (2.19 KB, patch)
2011-11-30 02:31 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-11-30 01:42:01 PST 
Patch forthcoming
Comment 1 Filip Pizlo 2011-11-30 01:43:34 PST 
Created attachment 117141 [details]
the patch
Comment 2 Filip Pizlo 2011-11-30 01:51:22 PST 
Comment on attachment 117141 [details]
the patch

Marking cq? because I'm going to bed.
Comment 3 Csaba Osztrogonác 2011-11-30 02:23:51 PST 
Comment on attachment 117141 [details]
the patch

r- now, because it doesn't build. I'm going to fix it ASAP.
Comment 4 Csaba Osztrogonác 2011-11-30 02:31:48 PST 
Created attachment 117150 [details]
Patch
Comment 5 Gabor Loki 2011-11-30 02:50:35 PST 
Comment on attachment 117150 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117150&action=review

> Source/JavaScriptCore/assembler/ARMAssembler.h:800
> +            return reinterpret_cast<void*>(readPointer(reinterpret_cast<void*>(getAbsoluteJumpAddress(from))));

No need for that outer reinterpret_cast, the readPointer return with void*.

The patch runs without any js regression, rs=me  ;)
Comment 6 Csaba Osztrogonác 2011-11-30 03:09:21 PST 
Comment on attachment 117150 [details]
Patch

Landed in http://trac.webkit.org/changeset/101473
Comment 7 Filip Pizlo 2011-11-30 11:09:34 PST 
(In reply to comment #6)
> (From update of attachment 117150 [details])
> Landed in http://trac.webkit.org/changeset/101473

Thanks for fixing this!