Bug 73352 - Use contentsToRootView when converting the mouse coordinates for the context menu key event
Summary: Use contentsToRootView when converting the mouse coordinates for the context ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks: 71945
  Show dependency tree / graph
 
Reported: 2011-11-29 12:52 PST by Anders Carlsson
Modified: 2011-11-29 13:30 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2011-11-29 12:53 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (1.66 KB, patch)
2011-11-29 13:23 PST, Anders Carlsson 		aroben: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-11-29 12:52:29 PST 
Use contentsToRootView when converting the mouse coordinate for the context menu key event
Comment 1 Anders Carlsson 2011-11-29 12:53:21 PST 
Created attachment 117026 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-11-29 12:53:48 PST 
Comment on attachment 117026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117026&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

Why not?
Comment 3 Adam Roben (:aroben) 2011-11-29 12:54:14 PST 
What is the symptom this patch fixes? Your bug title should describe it.
Comment 4 Anders Carlsson 2011-11-29 13:07:50 PST 
(In reply to comment #2)
> (From update of attachment 117026 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117026&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests. (OOPS!)
> 
> Why not?

This should already be covered by existing tests.

(In reply to comment #3)
> What is the symptom this patch fixes? Your bug title should describe it.

Another part of https://bugs.webkit.org/show_bug.cgi?id=71945 - I'll relate the bugs and put the info in the change log.
Comment 5 Anders Carlsson 2011-11-29 13:23:00 PST 
Created attachment 117033 [details]
Patch
Comment 6 Adam Roben (:aroben) 2011-11-29 13:23:48 PST 
Comment on attachment 117033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117033&action=review

> Source/WebCore/ChangeLog:12
> +        Use contentsToRootView when converting the mouse coordinates for the context menu key event
> +        https://bugs.webkit.org/show_bug.cgi?id=73352
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        This is another step towards fixing https://bugs.webkit.org/show_bug.cgi?id=71945, by getting
> +        rid of a call to ScrollView::contentsToWindow.
> +
> +        * page/EventHandler.cpp:
> +        (WebCore::EventHandler::sendContextMenuEventForKey):

You should mention why you haven't modified/added any tests.
Comment 7 Anders Carlsson 2011-11-29 13:30:35 PST 
Committed r101416: <http://trac.webkit.org/changeset/101416>