NEW 71945
Eliminate the notion of a window coordinate system from WebCore 
https://bugs.webkit.org/show_bug.cgi?id=71945
Summary Eliminate the notion of a window coordinate system from WebCore
Anders Carlsson
Reported 2011-11-09 13:00:42 PST
WebCore shouldn't need to know anything about window coordinates - especially not in Chromium and WebKit2 where the WebCore widget hierarchy is in a completely different process from the actual window! We should try to eliminate calls to convertToContainingWindow/convertFromContainingWindow etc and replace them with convertToRootView/convertFromRootView. The only case where window coordinates are important is in Mac WebKit1 due to the way it works with AppKit, but we should try to keep that code in the WebKit1 code.
Attachments
Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2011-11-09 13:07:05 PST
Awesome plan!
Darin Adler
Comment 2 2011-11-09 16:11:28 PST
Don’t window coordinates matter for things like window.screen, window.screenLeft, window.screenTop, window.innerHeight, window.outerHeight?
Anders Carlsson
Comment 3 2011-11-29 13:16:03 PST
(In reply to comment #2) > Don’t window coordinates matter for things like window.screen, window.screenLeft, window.screenTop, window.innerHeight, window.outerHeight? Nope. for window.outerHeight/window.innerHeight we have a ChromeClient function to get the window rect (in screen coordinates). Nowhere in WebCore itself do we need to use window coordinates.
Note You need to log in before you can comment on or make changes to this bug.