Bug 73150 – [Qt] [WK2] Remove WebContext related code from QtWebPageProxy

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Caio Marcelo de Oliveira Filho]

[Qt] [WK2] Remove WebContext related code from QtWebPageProxy

[Caio Marcelo de Oliveira Filho]

Created attachment 116643 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 116643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116643&action=review

> Source/WebKit2/UIProcess/qt/QtWebContext.cpp:49
> +// Used only by WebKitTestRunner. Not calling initialize() so we don't register any clients.

It avoids calling initialize(), so that we don't ...

> Source/WebKit2/UIProcess/qt/QtWebContext.cpp:64
> +    defaultContext->initialize();
> +    return defaultContext.release();

I prefer a newline before the return. It makes it easier to spot that it returns something

> Source/WebKit2/UIProcess/qt/QtWebContext.cpp:67
> +PassRefPtr<WebPageProxy> QtWebContext::createWebPage(PageClient* pageClient, WebPageGroup* webPageGroup)

Personally I would just call the arguments for client and pageGroup. At least pageGroup should be enough

> Source/WebKit2/UIProcess/qt/QtWebContext.cpp:72
> +void QtWebContext::setNavigatorQtObjectEnabled(WebPageProxy* webPageProxy, bool enabled)

What about setNavigationDotQtJSObjectEnabled...  It is hard to figure out what NavigationQt is all about

> Source/WebKit2/UIProcess/qt/QtWebContext.cpp:98
> +void QtWebContext::setupContextInjectedBundleClient()

Any reason this is called setup and not initialize?

[Caio Marcelo de Oliveira Filho]

Created attachment 116649 [details]
Patch for landing

[Caio Marcelo de Oliveira Filho]

Comment on attachment 116643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116643&action=review

Thanks for the review. Followed your suggestions in the version for landing -- except for one.

>> Source/WebKit2/UIProcess/qt/QtWebContext.cpp:72
>> +void QtWebContext::setNavigatorQtObjectEnabled(WebPageProxy* webPageProxy, bool enabled)
> 
> What about setNavigationDotQtJSObjectEnabled...  It is hard to figure out what NavigationQt is all about

I have some work on navigator.qt object on the queue, so I'll fix that naming in a next patch.

[WebKit Review Bot]

Comment on attachment 116649 [details]
Patch for landing

Clearing flags on attachment: 116649

Committed r101188: <http://trac.webkit.org/changeset/101188>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.