Bug 73019 - Web Inspector: split console agent into worker and page console agents
Summary: Web Inspector: split console agent into worker and page console agents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks: 58541
  Show dependency tree / graph
 
Reported: 2011-11-23 06:18 PST by Yury Semikhatsky
Modified: 2011-11-23 22:17 PST (History)
10 users (show)

See Also:

Attachments
Patch (54.02 KB, patch)
2011-11-23 06:23 PST, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2011-11-23 06:18:30 PST 
Some console functionality is not supported in workers, e.g. addInspectedNode has no sense for worker since there is no DOM tree. I'd like to split the agent into worker and page specific descendants.
Comment 1 Yury Semikhatsky 2011-11-23 06:23:25 PST 
Created attachment 116351 [details]
Patch
Comment 2 Yury Semikhatsky 2011-11-23 07:29:01 PST 
Committed r101081: <http://trac.webkit.org/changeset/101081>
Comment 3 Timothy Hatcher 2011-11-23 18:21:53 PST 
What is the bigger picture here? Do workers get their own Inspector?
Comment 4 Yury Semikhatsky 2011-11-23 22:17:26 PST 
(In reply to comment #3)
> What is the bigger picture here? Do workers get their own Inspector?

Worker inspection meta bug describes this in details: https://bugs.webkit.org/show_bug.cgi?id=58541

At the moment we can list all dedicated workers in the Page's inspector and open separate inspector for each of them. It requires window.open to work inside inspector front-end on the platform. In WebKit2 it is blocked by https://bugs.webkit.org/show_bug.cgi?id=72506.

Shared worker also can be inspected using its own web inspector. The idea is to have some discovery page for shared workers which would allow opening inspector front-end for each shared worker. In Chromium we use browser task manager for discovering shared worker processes and inspecting them.