Bug 72506 – [WebKit2] Web Inspector: window.open should work inside inspector front-end

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Web Inspector

[Yury Semikhatsky]

window.open needs to be implemented for inspector front-end pages in order to open inspector windows for dedicated workers.

[Yury Semikhatsky]

Created attachment 115380 [details]
Patch

[Yury Semikhatsky]

(In reply to comment #1)
> Created an attachment (id=115380) [details]
> Patch

I'm not sure if it is correct approach to initialize one WebUIClient from another or should we only copy createNewPage* mehods and version on the corresponding WKPageUIClient instances.

[Yury Semikhatsky]

Timothy or Joseph, can you take a look at this change?

[Timothy Hatcher]

What do you mean by "open inspector windows for dedicated workers"? Workers as in the Workers API or just helper windows?

[Timothy Hatcher]

Comment on attachment 115380 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115380&action=review

> Source/WebKit2/ChangeLog:6
> +        Inspector front-end page now has the same WebUIClient as inspected page.

Please describe the reason/motivation for these changes.

[Yury Semikhatsky]

(In reply to comment #4)
> What do you mean by "open inspector windows for dedicated workers"? Workers as in the Workers API or just helper windows?

I meant that we need this to inspect dedicated workers running inside inspected page. Page inspector lists all running workers and should allow opening separate inspector front-end for each of them. To open such front-end from the page's inspector front-end we need window.open() to work there.

[Yury Semikhatsky]

Created attachment 115600 [details]
Patch

[Timothy Hatcher]

I'd like Sam or Anders to look at this.

[Timothy Hatcher]

Comment on attachment 115600 [details]
Patch

Sorry for not giving this much thought earlier. But now that I understand what is going on here, this should not land.

Hooking up the inspected page's UI client to a non-Safari created WKView is a bad idea (breaking some assumptions that Safari has the WKPage that gets passed ot its client).

Also windows opened with window.open will be Safari windows, not WebKit controlled windows. You will have Find in Page and other browser features in the window.open windows that don't (and shouldn't exist) in the Web Inspector.

We should implement a UIClient in WebKit2 that handles window.open and makes a WebKit owned window/WKView.

This patch is all about WebKit2, but we should implement this in WebKit also, which still has the Web Inspector and is used by clients other than Safari.

[Brian Burg]

I don't think we have any need for opening extra inspector windows, as workers are not inspectable right now. In any case, the WK2 bits will need to be rewritten.

[Radar WebKit Bug Importer]

<rdar://problem/17898462>

[Timothy Hatcher]

YEah and our ideal worker debugging experience is not a separate window.