Bug 72986 - [MutationObservers] Cleanup duplicated code in Element & CharacterData
Summary: [MutationObservers] Cleanup duplicated code in Element & CharacterData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rafael Weinstein
URL:
Keywords:
Depends on:
Blocks: 68729
  Show dependency treegraph
 
Reported: 2011-11-22 14:14 PST by Rafael Weinstein
Modified: 2011-11-23 02:46 PST (History)
5 users (show)

See Also:


Attachments
Patch (14.73 KB, patch)
2011-11-22 14:18 PST, Rafael Weinstein
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Weinstein 2011-11-22 14:14:42 PST
There is nearly indentical code in Element & CharacterData which collects a set of interested MutationObservers, creates appropriate mutation records (with & without oldValues) and delivers them.

We should create some sort of "MutationObserverInterestGroup" which encapsulates this logic
Comment 1 Rafael Weinstein 2011-11-22 14:18:21 PST
Created attachment 116275 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-23 02:46:19 PST
Comment on attachment 116275 [details]
Patch

Clearing flags on attachment: 116275

Committed r101061: <http://trac.webkit.org/changeset/101061>
Comment 3 WebKit Review Bot 2011-11-23 02:46:24 PST
All reviewed patches have been landed.  Closing bug.