Bug 72959 – [Qt] [WK2] Move PagePolicyClient related code to QtWebPagePolicyClient

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Caio Marcelo de Oliveira Filho]

[Qt] [WK2] Move PagePolicyClient related code to QtWebPagePolicyClient

[Caio Marcelo de Oliveira Filho]

Created attachment 116228 [details]
Patch

[Andreas Kling]

Comment on attachment 116228 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116228&action=review

r=me with some nits that you don't need to fix in this patch, but may want to consider in the future. :)

> Source/WebKit2/UIProcess/qt/QtWebPagePolicyClient.cpp:64
> +static Qt::MouseButton toQtMouseButton(WKEventMouseButton button)
> +{
> +    switch (button) {
> +    case kWKEventMouseButtonLeftButton:
> +        return Qt::LeftButton;
> +    case kWKEventMouseButtonMiddleButton:
> +        return Qt::MiddleButton;
> +    case kWKEventMouseButtonRightButton:
> +        return Qt::RightButton;
> +    }
> +    return Qt::NoButton;
> +}

In this kind of method, we should have a case for kWKEventMouseButtonNoButton (returning Qt::NoButton) and then putting an ASSERT_NOT_REACHED() after the switch.

> Source/WebKit2/UIProcess/qt/QtWebPagePolicyClient.cpp:97
> +    switch (action) {
> +    case Use:
> +        WKFramePolicyListenerUse(listener);
> +        break;
> +    case Download:
> +        WKFramePolicyListenerDownload(listener);
> +        break;
> +    case Ignore:
> +        WKFramePolicyListenerIgnore(listener);
> +        break;
> +    }

Similar situation here, we could replace the breaks by returns and put an ASSERT_NOT_REACHED() after the switch.

[Caio Marcelo de Oliveira Filho]

Committed r101071: <http://trac.webkit.org/changeset/101071>