Eric landed a change related to port factory as follows.
This change miss to fix new-run-webkit-websocketserver.
Created attachment 116033 [details]
Comment on attachment 116033 [details]
Thank you. We should consider moving the guts of this script into webkitpy/websocketserver/main.py or similar to avoid breaking. Keeping our python code all under one directory makes dependency tracking easier.
I might also recommend putting the host in a local variable, as you're likely to want the filesystem or executive off it.
Also, currently you have to call host._initialize_scm() after creating the host if you want it to have an SCM or Checkout object.
Created attachment 116035 [details]
Thank you Eric.
For now, I just change to keep host in a local variable.
We'll put them into webkitpy/websocketserver/... in future.
Comment on attachment 116035 [details]
Clearing flags on attachment: 116035
Committed r100889: <http://trac.webkit.org/changeset/100889>
All reviewed patches have been landed. Closing bug.