Bug 72859 - new-run-webkit-websocketserver must use Host().port_factory, too
Summary: new-run-webkit-websocketserver must use Host().port_factory, too
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-20 23:23 PST by Takashi Toyoshima
Modified: 2011-11-21 01:12 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.56 KB, patch)
2011-11-20 23:25 PST, Takashi Toyoshima
no flags Details | Formatted Diff | Diff
Patch (1.57 KB, patch)
2011-11-20 23:45 PST, Takashi Toyoshima
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Takashi Toyoshima 2011-11-20 23:23:33 PST
Eric landed a change related to port factory as follows.
https://bugs.webkit.org/show_bug.cgi?id=71961

This change miss to fix new-run-webkit-websocketserver.
Comment 1 Takashi Toyoshima 2011-11-20 23:25:58 PST
Created attachment 116033 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-11-20 23:28:44 PST
Comment on attachment 116033 [details]
Patch

Thank you.  We should consider moving the guts of this script into webkitpy/websocketserver/main.py or similar to avoid breaking.  Keeping our python code all under one directory makes dependency tracking easier.
Comment 3 Eric Seidel (no email) 2011-11-20 23:29:41 PST
I might also recommend putting the host in a local variable, as you're likely to want the filesystem or executive off it.

Also, currently you have to call host._initialize_scm() after creating the host if you want it to have an SCM or Checkout object.
Comment 4 Takashi Toyoshima 2011-11-20 23:45:16 PST
Created attachment 116035 [details]
Patch
Comment 5 Takashi Toyoshima 2011-11-20 23:48:17 PST
Thank you Eric.
For now, I just change to keep host in a local variable.

We'll put them into webkitpy/websocketserver/... in future.
Comment 6 WebKit Review Bot 2011-11-21 01:12:23 PST
Comment on attachment 116035 [details]
Patch

Clearing flags on attachment: 116035

Committed r100889: <http://trac.webkit.org/changeset/100889>
Comment 7 WebKit Review Bot 2011-11-21 01:12:28 PST
All reviewed patches have been landed.  Closing bug.