Bug 7276 – Most W3C padding related tests fail

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: CSS

[Diego Miguel Virasoro]

I have tested Safari using the latest webkit (15th Feb) and it fails the following tests regarding paddings:

PADDING TOP
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5506-ipadn-t-00-b-a.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5506-ipadn-t-01-b-a.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5506-ipadn-t-02-b-a.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5506-padn-t-00-b-a.htm

PADDING RIGHT
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5507-ipadn-r-00-b-ag.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5507-ipadn-r-01-b-ag.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5507-ipadn-r-02-b-ag.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5507-ipadn-r-03-b-a.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5507-ipadn-r-04-b-ag.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5507-padn-r-00-c-ag.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5507-padn-r-01-c-a.htm

PADDING BOTTOM
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5508-ipadn-b-00-b-a.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5508-ipadn-b-01-f-a.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5508-ipadn-b-02-b-a.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5508-ipadn-b-03-b-a.htm

PADDING RIGHT
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5509-ipadn-l-00-b-ag.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5509-ipadn-l-01-b-ag.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5509-ipadn-l-02-b-ag.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5509-ipadn-l-03-b-a.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5509-ipadn-l-04-f-ag.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5509-padn-l-00-b-ag.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5509-padn-l-01-b-a.htm

PADDING
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5510-ipadn-00-b-ag.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5510-padn-00-b-ag.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5510-padn-01-e-a.htm

[Alexey Proskuryakov]

I think that the reason why you are seeing failures is that you don't have Ahem font installed (<http://webkit.opendarwin.org/quality/Ahem.ttf>). 

This special simple font is used to construct certain types of predictable tests. A page on Ian Hickson's site <http://www.hixie.ch/resources/fonts/> has a more detailed explanation.

[Diego Miguel Virasoro]

Indeed you were right. That has chanaged the appearances a lot. However there are still some small problems.

http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5506-ipadn-t-00-b-a.htm
1px horizontal link on top of the green bar

http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5506-ipadn-t-01-b-a.htm
lighter green line across the bar (exactly halfway)

http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5506-padn-t-00-b-a.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5508-ipadn-b-03-b-a.htm
Both show a small white column (maybe width=7px) between the colorful rows and the black right border

http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5507-ipadn-r-02-b-ag.htm
lighter green vertical line across the square (exactly halfway)

http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5508-ipadn-b-00-b-a.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5508-ipadn-b-01-f-a.htm
both show the lighter green vertical line across the bar (exactly halway)

http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5509-ipadn-l-02-b-ag.htm
there is also a red square which should be absent

[David Kilzer (:ddkilzer)]

I think the reporter would like this bug to be reopened per Comment #2.

[Alexey Proskuryakov]

Three of these tests are failing for me, and have identically broken results checked in:
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5509-ipadn-l-02-b-ag.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5508-ipadn-b-03-b-a.htm
http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5506-padn-t-00-b-a.htm

Other tests start to break if I zoom in with Cmd+=. This might be an expected behavior.

[Gustaaf Groenendaal (MysteryQuest)]

Confirming this, but please note that CSS 2.1 is not fully supported and that this is a to-do.

Description: Add padding to CSS 2.1

[Joost de Valk (AlthA)]

This is still under discussion, however, i HAVE found this problem to be real myself as well.

[Robert Blaut]

All above mentioned tests renders correctly (except this test: http://www.w3.org/Style/CSS/Test/CSS2.1/current/t0804-c5509-ipadn-l-02-b-ag.htm) in Webkit r30001.

Other issues are related to antialiasing problem described in bug 17806. After turning font antialiasing off the issues disappear.

[Robert Blaut]

I mean bug 17086 :o

[Anatoli Papirovski]

Created attachment 21016 [details]
patch

I've created a patch for this, however the bidi.cpp is rather confusing, so I'm just hoping I did not break anything else... I ran all the tests from LayoutTests and nothing seems to be broken.

I'm happy to change whatever, since as I said, I barely knew what I was doing...

Created attachment 21018 [details]
A test case without padding

I don't understand:
1) Why the test is correct
2) How the failure is specific to padding (and therefore why the patch is correct)

Is WebKit's rendering of this test case correct? If not, I think that's what should be fixed, not anything specific to padding.

[Robert Blaut]

Created attachment 21032 [details]
test case for "spanned" string wrapping 

I think the initial CSS 2.1 test exposes bug in Webkit which is completely unrelated to padding.

I my opinion Webkit incorrectly wraps "spanned" strings: "This_line<span>should_not</span>be_wrapped."

Comment on attachment 21016 [details]
patch

This does not seem to address the root cause of the test failure.

[Anatoli Papirovski]

Hmm, makes sense to me... For some reason I completely missed the fact that it was x<span>x</span> rathern than a padding issue... 

Bug 18926 is essentially the same issue.

[Ahmad Saleem]

Based on attached test cases, I am unable to reproduce the bug in Safari 15.5 on macOS 12.4 from visual perspective, there is no difference between Safari 15.5 with other browsers (Chrome Canary 104 and Firefox Nightly 103).

Is it something, which got fixed along the lines? Thanks!

[alan]

(In reply to Ahmad Saleem from comment #15)
> Based on attached test cases, I am unable to reproduce the bug in Safari
> 15.5 on macOS 12.4 from visual perspective, there is no difference between
> Safari 15.5 with other browsers (Chrome Canary 104 and Firefox Nightly 103).
> 
> Is it something, which got fixed along the lines? Thanks!
Yeah I am pretty sure it did. This is rather basic.