Bug 17806 - Arena.h's CLEAR_UNUSED should use statement1;statement2 instead of (statement1,statement2)
Summary: Arena.h's CLEAR_UNUSED should use statement1;statement2 instead of (statement...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-12 14:04 PDT by Mark Mentovai
Modified: 2008-03-13 20:45 PDT (History)
0 users

See Also:

Attachments
Fix (1.20 KB, patch)
2008-03-12 14:05 PDT, Mark Mentovai 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Mentovai 2008-03-12 14:04:21 PDT 
I don't think this (statement1,statement2) thing is necessary, and it's causing trouble for me in a build with DEBUG defined.

As far as I'm aware, the only use of CLEAR_UNUSED is in Arena.cpp.
Comment 1 Mark Mentovai 2008-03-12 14:05:06 PDT 
Created attachment 19710 [details]
Fix
Comment 2 Eric Seidel (no email) 2008-03-12 14:17:41 PDT 
Comment on attachment 19710 [details]
Fix

I don't understand why your compiler would barf here.  Or why our build doesn't barf.  But the change looks sane.  r=me.
Comment 3 Eric Seidel (no email) 2008-03-13 20:45:45 PDT 
Thank you mark for making such easy-to-land patches.  These took only a few minutes to land on my train ride home. :)

These are revisions r31048 through r31053