Bug 72612 – [Qt][WK2] REGRESSION(100483): It made 2 API tests fail

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Csaba Osztrogonác]

FAIL!  : qmltests::DesktopWebViewLinkHovered::test_linkHovered() 'wait for signal linkHovered' returned FALSE. ()
   Loc: [/usr/local/Trolltech/Qt5/Qt-5.0.0-r11/imports/QtTest/TestCase.qml(473)]
FAIL!  : qmltests::DesktopWebViewLinkHovered::test_linkHoveredDoesntEmitRepeated() 'wait for signal linkHovered' returned FALSE. ()
   Loc: [/usr/local/Trolltech/Qt5/Qt-5.0.0-r11/imports/QtTest/TestCase.qml(473)]

[Alexis Menard (darktears)]

Grab it, I'm on it.

[Alexis Menard (darktears)]

Created attachment 116108 [details]
Patch

[Tor Arne Vestbø]

Comment on attachment 116108 [details]
Patch

It should not be necessary for the user of the API to do this themselves. We should fix it in WebKit, not in a test.

[Alexis Menard (darktears)]

(In reply to comment #3)
> (From update of attachment 116108 [details])
> It should not be necessary for the user of the API to do this themselves. We should fix it in WebKit, not in a test.

Well QML doesn't have a concept of default focus item...

Ok let's say the view as the focus then we need to fix 


bool QtWebPageProxy::isViewFocused()
{
    return m_qmlWebPage->hasFocus();
}


to


bool QtWebPageProxy::isViewFocused()
{
    return m_qmlWebView->hasFocus();
}

which I did first.

[Alexis Menard (darktears)]

Created attachment 116125 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 116125 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116125&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h:119
> +    virtual void focusInEvent(QFocusEvent *);
> +    virtual void focusOutEvent(QFocusEvent *);

wrong coding style

[Alexis Menard (darktears)]

Committed r100955: <http://trac.webkit.org/changeset/100955>