Bug 72612 - [Qt][WK2] REGRESSION(100483): It made 2 API tests fail
Summary: [Qt][WK2] REGRESSION(100483): It made 2 API tests fail
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Critical
Assignee: Alexis Menard (darktears)
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 70236
  Show dependency treegraph
 
Reported: 2011-11-17 07:58 PST by Csaba Osztrogonác
Modified: 2011-11-21 13:45 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.42 KB, patch)
2011-11-21 11:19 PST, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff
Patch (4.17 KB, patch)
2011-11-21 13:29 PST, Alexis Menard (darktears)
kenneth: review+
kenneth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-11-17 07:58:15 PST
FAIL!  : qmltests::DesktopWebViewLinkHovered::test_linkHovered() 'wait for signal linkHovered' returned FALSE. ()
   Loc: [/usr/local/Trolltech/Qt5/Qt-5.0.0-r11/imports/QtTest/TestCase.qml(473)]
FAIL!  : qmltests::DesktopWebViewLinkHovered::test_linkHoveredDoesntEmitRepeated() 'wait for signal linkHovered' returned FALSE. ()
   Loc: [/usr/local/Trolltech/Qt5/Qt-5.0.0-r11/imports/QtTest/TestCase.qml(473)]
Comment 1 Alexis Menard (darktears) 2011-11-21 09:59:58 PST
Grab it, I'm on it.
Comment 2 Alexis Menard (darktears) 2011-11-21 11:19:36 PST
Created attachment 116108 [details]
Patch
Comment 3 Tor Arne Vestbø 2011-11-21 12:29:05 PST
Comment on attachment 116108 [details]
Patch

It should not be necessary for the user of the API to do this themselves. We should fix it in WebKit, not in a test.
Comment 4 Alexis Menard (darktears) 2011-11-21 12:57:20 PST
(In reply to comment #3)
> (From update of attachment 116108 [details])
> It should not be necessary for the user of the API to do this themselves. We should fix it in WebKit, not in a test.

Well QML doesn't have a concept of default focus item...

Ok let's say the view as the focus then we need to fix 


bool QtWebPageProxy::isViewFocused()
{
    return m_qmlWebPage->hasFocus();
}


to


bool QtWebPageProxy::isViewFocused()
{
    return m_qmlWebView->hasFocus();
}

which I did first.
Comment 5 Alexis Menard (darktears) 2011-11-21 13:29:28 PST
Created attachment 116125 [details]
Patch
Comment 6 Kenneth Rohde Christiansen 2011-11-21 13:33:56 PST
Comment on attachment 116125 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=116125&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h:119
> +    virtual void focusInEvent(QFocusEvent *);
> +    virtual void focusOutEvent(QFocusEvent *);

wrong coding style
Comment 7 Alexis Menard (darktears) 2011-11-21 13:45:47 PST
Committed r100955: <http://trac.webkit.org/changeset/100955>