Bug 72601 - [GTK] enable ref tests
Summary: [GTK] enable ref tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-17 04:51 PST by Philippe Normand
Modified: 2011-11-17 15:01 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.78 KB, patch)
2011-11-17 11:40 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (2.63 KB, patch)
2011-11-17 12:08 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2011-11-17 04:51:56 PST
They were disabled in bug 72599
Comment 1 Zan Dobersek 2011-11-17 11:40:25 PST
Created attachment 115635 [details]
Patch

This is a small hack, adding 20 to the display number when the driver is also doing the pixel tests. It theoretically works as long as the number of workers is below 20, so feel free to advise on what to actually do to make this bullet-proof. The basic idea is for each driver to have its own Xvfb process up and running. This is the reason of the flakiness that caused bug #72599 to disable the ref tests.
Comment 2 Tony Chang 2011-11-17 11:51:48 PST
Comment on attachment 115635 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115635&action=review

Thanks for tracking this down!

> Tools/Scripts/webkitpy/layout_tests/port/gtk.py:53
> +        if self._pixel_tests:
> +            display_id += 20

We have machines with 24 cores.  Instead of adding a constant, we could have:
display_id = (self._worker_number + 1) * 2
if self._pixel_tests:
    display_id += 1
Comment 3 Zan Dobersek 2011-11-17 12:08:05 PST
Created attachment 115649 [details]
Patch

Thanks for the review! Rather used 'self._worker_number * 2 + 1', just to number the displays from 1 onwards.
Comment 4 Tony Chang 2011-11-17 12:15:44 PST
Comment on attachment 115649 [details]
Patch

Thanks!
Comment 5 WebKit Review Bot 2011-11-17 15:01:35 PST
Comment on attachment 115649 [details]
Patch

Clearing flags on attachment: 115649

Committed r100683: <http://trac.webkit.org/changeset/100683>
Comment 6 WebKit Review Bot 2011-11-17 15:01:40 PST
All reviewed patches have been landed.  Closing bug.