Bug 72601 – [GTK] enable ref tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Philippe Normand]

They were disabled in bug 72599

[Zan Dobersek]

Created attachment 115635 [details]
Patch

This is a small hack, adding 20 to the display number when the driver is also doing the pixel tests. It theoretically works as long as the number of workers is below 20, so feel free to advise on what to actually do to make this bullet-proof. The basic idea is for each driver to have its own Xvfb process up and running. This is the reason of the flakiness that caused bug #72599 to disable the ref tests.

[Tony Chang]

Comment on attachment 115635 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115635&action=review

Thanks for tracking this down!

> Tools/Scripts/webkitpy/layout_tests/port/gtk.py:53
> +        if self._pixel_tests:
> +            display_id += 20

We have machines with 24 cores.  Instead of adding a constant, we could have:
display_id = (self._worker_number + 1) * 2
if self._pixel_tests:
    display_id += 1

[Zan Dobersek]

Created attachment 115649 [details]
Patch

Thanks for the review! Rather used 'self._worker_number * 2 + 1', just to number the displays from 1 onwards.

[Tony Chang]

Comment on attachment 115649 [details]
Patch

Thanks!

[WebKit Review Bot]

Comment on attachment 115649 [details]
Patch

Clearing flags on attachment: 115649

Committed r100683: <http://trac.webkit.org/changeset/100683>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.