Bug 72599 - [GTK] Disable ref tests
Summary: [GTK] Disable ref tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 312.x
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-17 04:36 PST by Philippe Normand
Modified: 2011-11-17 11:42 PST (History)
6 users (show)

See Also:


Attachments
proposed patch (1.56 KB, patch)
2011-11-17 04:40 PST, Philippe Normand
xan.lopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2011-11-17 04:36:52 PST
http://trac.webkit.org/changeset/100326 made the GTK bots incredibly flaky, more than 40...
Disabling ref tests fixes this issue, we should investigate this further and re-enable ref tests at some point but what we need now is stable bots.

Thanks to Zan for the help on this.
Comment 1 Philippe Normand 2011-11-17 04:40:26 PST
Created attachment 115563 [details]
proposed patch
Comment 2 Xan Lopez 2011-11-17 04:47:39 PST
Comment on attachment 115563 [details]
proposed patch

OK. Please open a bug to track this, thanks!
Comment 3 Philippe Normand 2011-11-17 04:54:34 PST
Committed r100605: <http://trac.webkit.org/changeset/100605>
Comment 4 Tony Chang 2011-11-17 10:16:34 PST
Sorry about that!  I'll see if I can repro.
Comment 5 Zan Dobersek 2011-11-17 11:42:33 PST
(In reply to comment #4)
> Sorry about that!  I'll see if I can repro.

A basic patch that fixes this is up at bug #72601. It's more of a quick hack, but the problem was that DriverProxy created two drivers, both using the same Xvfb instance, which caused the flakiness.