Bug 72577 - Remove all custom constructors of Events from JSC
Summary: Remove all custom constructors of Events from JSC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
: 72255 (view as bug list)
Depends on:
Blocks: 71379
  Show dependency treegraph
 
Reported: 2011-11-16 18:57 PST by Kentaro Hara
Modified: 2011-11-17 06:39 PST (History)
7 users (show)

See Also:


Attachments
Patch (48.39 KB, patch)
2011-11-16 22:26 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-11-16 18:57:02 PST
Now CodeGeneratorV8.pm can generate Event constructors using [ConstructorTemplate=Event] IDL (bug 72055). CodeGeneratorJS.pm should also generate Event constructors by the IDL. By doing this, we can remove EventConstructors.h and JSEventConstructors.cpp.
Comment 1 Kentaro Hara 2011-11-16 22:26:40 PST
Created attachment 115525 [details]
Patch
Comment 2 Adam Barth 2011-11-16 22:31:54 PST
Comment on attachment 115525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115525&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3249
> +    if (IsConstructorTemplate($dataNode, "Event")) {

I might have called IsConstructorTemplate something like HasConstructorTemplate, but it's probably better to be consistent with the V8 code generator.
Comment 3 WebKit Review Bot 2011-11-16 23:11:52 PST
Comment on attachment 115525 [details]
Patch

Clearing flags on attachment: 115525

Committed r100564: <http://trac.webkit.org/changeset/100564>
Comment 4 WebKit Review Bot 2011-11-16 23:11:57 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Kentaro Hara 2011-11-17 06:39:18 PST
*** Bug 72255 has been marked as a duplicate of this bug. ***