Bug 72255 - Make CodeGeneratorJS.pm generate Event constructors
Summary: Make CodeGeneratorJS.pm generate Event constructors
Status: RESOLVED DUPLICATE of bug 72577
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 71379
  Show dependency tree / graph
 
Reported: 2011-11-14 03:17 PST by Kentaro Hara
Modified: 2011-11-17 06:39 PST (History)
7 users (show)

See Also:

Attachments
Patch (17.32 KB, patch)
2011-11-14 03:39 PST, Kentaro Hara 		abarth: review+
Details | Formatted Diff | Diff
Try again to see if build succeeds (17.32 KB, patch)
2011-11-14 10:21 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Try again to see if the win build looks happy (17.32 KB, patch)
2011-11-15 06:23 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
To see if win build looks happy (18.57 KB, patch)
2011-11-15 07:04 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
Another try (19.03 KB, patch)
2011-11-16 12:30 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-11-14 03:17:02 PST 
Now CodeGeneratorV8.pm can generate Event constructors using [ConstructorTemplate=Event] IDL (bug 72055). CodeGeneratorJS.pm should also generate the Event constructors.
Comment 1 Kentaro Hara 2011-11-14 03:39:16 PST 
Created attachment 114911 [details]
Patch
Comment 2 Adam Barth 2011-11-14 08:48:09 PST 
Comment on attachment 114911 [details]
Patch

Looks like the win-ews is red.
Comment 3 Kentaro Hara 2011-11-14 10:21:39 PST 
Created attachment 114975 [details]
Try again to see if build succeeds
Comment 4 Kentaro Hara 2011-11-15 06:23:38 PST 
Created attachment 115152 [details]
Try again to see if the win build looks happy
Comment 5 Kentaro Hara 2011-11-15 07:04:15 PST 
Created attachment 115159 [details]
To see if win build looks happy
Comment 6 Kentaro Hara 2011-11-16 12:30:13 PST 
Created attachment 115422 [details]
Another try
Comment 7 Kentaro Hara 2011-11-16 14:30:24 PST 
Adam: The patch has not yet passed win build... The problem seems to be related to how a template definition in a header file (i.e. JSDictionary::tryGetProperty) is treated when we try to separately compile cpp files which are using the header file and link them. 

By the way, this problem is just a "temporal" problem. If we land all the patches for bug 71379 and thus JSEventConstructors.cpp is removed, this problem will go away. (No error is occurring in win build with the WIP patch for bug 71379.) In summary, trying to address this problem is not so important in the end.

So is it OK to give up this patch and land the WIP patch for bug 71379 at a breath? (If it is OK, I will create a new bug for it and upload the patch for review again.)
Comment 8 Adam Barth 2011-11-16 16:56:58 PST 
Sure.  That's fine.
Comment 9 Kentaro Hara 2011-11-17 06:39:18 PST 

*** This bug has been marked as a duplicate of bug 72577 ***