RESOLVED DUPLICATE of bug 7257772255
Make CodeGeneratorJS.pm generate Event constructors 
https://bugs.webkit.org/show_bug.cgi?id=72255
Summary Make CodeGeneratorJS.pm generate Event constructors
Kentaro Hara
Reported 2011-11-14 03:17:02 PST
Now CodeGeneratorV8.pm can generate Event constructors using [ConstructorTemplate=Event] IDL (bug 72055). CodeGeneratorJS.pm should also generate the Event constructors.
Attachments
Patch (17.32 KB, patch)
2011-11-14 03:39 PST, Kentaro Hara 		abarth: review+
DetailsFormatted DiffDiff
Try again to see if build succeeds (17.32 KB, patch)
2011-11-14 10:21 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Try again to see if the win build looks happy (17.32 KB, patch)
2011-11-15 06:23 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
To see if win build looks happy (18.57 KB, patch)
2011-11-15 07:04 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Another try (19.03 KB, patch)
2011-11-16 12:30 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-11-14 03:39:16 PST
Created attachment 114911 [details] Patch
Adam Barth
Comment 2 2011-11-14 08:48:09 PST
Comment on attachment 114911 [details] Patch Looks like the win-ews is red.
Kentaro Hara
Comment 3 2011-11-14 10:21:39 PST
Created attachment 114975 [details] Try again to see if build succeeds
Kentaro Hara
Comment 4 2011-11-15 06:23:38 PST
Created attachment 115152 [details] Try again to see if the win build looks happy
Kentaro Hara
Comment 5 2011-11-15 07:04:15 PST
Created attachment 115159 [details] To see if win build looks happy
Kentaro Hara
Comment 6 2011-11-16 12:30:13 PST
Created attachment 115422 [details] Another try
Kentaro Hara
Comment 7 2011-11-16 14:30:24 PST
Adam: The patch has not yet passed win build... The problem seems to be related to how a template definition in a header file (i.e. JSDictionary::tryGetProperty) is treated when we try to separately compile cpp files which are using the header file and link them. By the way, this problem is just a "temporal" problem. If we land all the patches for bug 71379 and thus JSEventConstructors.cpp is removed, this problem will go away. (No error is occurring in win build with the WIP patch for bug 71379.) In summary, trying to address this problem is not so important in the end. So is it OK to give up this patch and land the WIP patch for bug 71379 at a breath? (If it is OK, I will create a new bug for it and upload the patch for review again.)
Adam Barth
Comment 8 2011-11-16 16:56:58 PST
Sure. That's fine.
Kentaro Hara
Comment 9 2011-11-17 06:39:18 PST
*** This bug has been marked as a duplicate of bug 72577 ***
Note You need to log in before you can comment on or make changes to this bug.