For some reason readyState has been implemented on TextTrack and it really should be on HTMLTrackElement.
<rdar://problem/10464479>
Created attachment 115662 [details] Patch
Comment on attachment 115662 [details] Patch Attachment 115662 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10312437 New failing tests: media/track/track-constants.html media/track/track-add-track.html
Created attachment 115717 [details] updating tests oops, forgot to update some other tests
Ping. This patch is ready for review.
Comment on attachment 115717 [details] updating tests View in context: https://bugs.webkit.org/attachment.cgi?id=115717&action=review > Source/WebCore/html/LoadableTextTrack.cpp:67 > + m_trackElement->setReadyState(HTMLTrackElement::LOADING); m_trackElement will be NULL if clearClient() has been called. > Source/WebCore/html/LoadableTextTrack.cpp:103 > + m_trackElement->setReadyState(HTMLTrackElement::LOADING); Dittol
Created attachment 116249 [details] Patch for landing
Comment on attachment 116249 [details] Patch for landing Clearing flags on attachment: 116249 Committed r101057: <http://trac.webkit.org/changeset/101057>
All reviewed patches have been landed. Closing bug.
Looks like this patch caused some build errors on windows. http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20Builder/builds/16732/steps/compile/logs/stdio I suspect it had to do with my attempt to remove the [Reflect]. I'll add it back and we'll try again.
Created attachment 116384 [details] bringin' back the Reflect
Comment on attachment 116384 [details] bringin' back the Reflect View in context: https://bugs.webkit.org/attachment.cgi?id=116384&action=review > Source/WebCore/html/HTMLTrackElement.h:57 > + enum ReadyState { NONE = 0, LOADING = 1, LOADED = 2, HTML_ERROR = 3 }; Although we used "HTML_ERROR" before, I don't think it is a good choice because "HTML" is too generic. Maybe "TRACK_ERROR" instead?
Thanks Eric, I'll change that before landing.
Committed r101213: <http://trac.webkit.org/changeset/101213>