Bug 72553 – Move readyState from TextTrack to HTMLTrackElement

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Anna Cavender]

For some reason readyState has been implemented on TextTrack and it really should be on HTMLTrackElement.

[Radar WebKit Bug Importer]

<rdar://problem/10464479>

[Anna Cavender]

Created attachment 115662 [details]
Patch

[WebKit Review Bot]

Comment on attachment 115662 [details]
Patch

Attachment 115662 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10312437

New failing tests:
media/track/track-constants.html
media/track/track-add-track.html

[Anna Cavender]

Created attachment 115717 [details]
updating tests

oops, forgot to update some other tests

[Anna Cavender]

Ping.  This patch is ready for review.

[Eric Carlson]

Comment on attachment 115717 [details]
updating tests

View in context: https://bugs.webkit.org/attachment.cgi?id=115717&action=review

> Source/WebCore/html/LoadableTextTrack.cpp:67
> +    m_trackElement->setReadyState(HTMLTrackElement::LOADING);

m_trackElement will be NULL if clearClient() has been called.

> Source/WebCore/html/LoadableTextTrack.cpp:103
> +    m_trackElement->setReadyState(HTMLTrackElement::LOADING);

Dittol

[Anna Cavender]

Created attachment 116249 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 116249 [details]
Patch for landing

Clearing flags on attachment: 116249

Committed r101057: <http://trac.webkit.org/changeset/101057>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Anna Cavender]

Looks like this patch caused some build errors on windows.
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20Builder/builds/16732/steps/compile/logs/stdio

I suspect it had to do with my attempt to remove the [Reflect].  I'll add it back and we'll try again.

[Anna Cavender]

Created attachment 116384 [details]
bringin' back the Reflect

[Eric Carlson]

Comment on attachment 116384 [details]
bringin' back the Reflect

View in context: https://bugs.webkit.org/attachment.cgi?id=116384&action=review

> Source/WebCore/html/HTMLTrackElement.h:57
> +    enum ReadyState { NONE = 0, LOADING = 1, LOADED = 2, HTML_ERROR = 3 };

Although we used "HTML_ERROR" before, I don't think it is a good choice because "HTML" is too generic. Maybe "TRACK_ERROR" instead?

[Anna Cavender]

Thanks Eric, I'll change that before landing.

[Anna Cavender]

Committed r101213: <http://trac.webkit.org/changeset/101213>