4.8.9 The track element
See descriptions of subtitles, captions, descriptions, chapters, and metadata.
Created attachment 118880 [details]
Attachment 118880 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/medi..." exit_code: 1
Source/WebCore/html/HTMLMediaElement.h:203: The parameter name "trackElement" adds no information, so it should be removed. [readability/parameter_name] 
Total errors found: 1 in 16 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 119286 [details]
Update patch as Alexey pointed out that track selection logic should not run until the media element has been closed.
Comment on attachment 119286 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=119286&action=review
> + Settings* settings = document()->settings();
You could pull the settings null check up here and avoid the duplication below.
(In reply to comment #5)
> (From update of attachment 119286 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=119286&action=review
> > Source/WebCore/html/HTMLMediaElement.cpp:2296
> > + Settings* settings = document()->settings();
> > +
> You could pull the settings null check up here and avoid the duplication below.
Thanks, I will fix that in a follow up patch so I can use the commit-queue on this one.
Or not. Committed by hand so I can get on with things.
Mac rebaseline done in http://trac.webkit.org/changeset/103642.