Bug 72371 - REGRESSION(r100213): "Breaks test_shell_tests" (Requested by tonyg-cr on #webkit).
Summary: REGRESSION(r100213): "Breaks test_shell_tests" (Requested by tonyg-cr on #web...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Review Bot
Depends on:
Blocks: 72308
  Show dependency treegraph
Reported: 2011-11-15 03:07 PST by WebKit Review Bot
Modified: 2011-11-16 19:59 PST (History)
3 users (show)

See Also:

ROLLOUT of r100213 (23.08 KB, patch)
2011-11-15 03:07 PST, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2011-11-15 03:07:10 PST
http://trac.webkit.org/changeset/100213 broke the build:
"Breaks test_shell_tests" (Requested by tonyg-cr on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2011-11-15 03:07:46 PST
Created attachment 115135 [details]
ROLLOUT of r100213

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Tony Gentilcore 2011-11-15 03:09:46 PST
I believe the patch is good, but unfortunately several tests were relying on the former loopholes. In order to avoid losing test coverage in the meantime and keep things rolling forward, I decided it is best to roll back for now. Sorry for the inconvenience.

Here's an example of the test_shell_tests that failed:
Comment 3 WebKit Review Bot 2011-11-15 03:15:04 PST
Comment on attachment 115135 [details]
ROLLOUT of r100213

Clearing flags on attachment: 115135

Committed r100262: <http://trac.webkit.org/changeset/100262>
Comment 4 WebKit Review Bot 2011-11-15 03:15:09 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Adam Barth 2011-11-16 19:59:49 PST
As far as I can tell, all of these tests are wrong.