RESOLVED FIXED 72308
Unique origins shouldn't remember their scheme, host, or port 
https://bugs.webkit.org/show_bug.cgi?id=72308
Summary Unique origins shouldn't remember their scheme, host, or port
Adam Barth
Reported 2011-11-14 14:15:34 PST
Unique origins shouldn't remember their scheme, host, or port
Attachments
Patch (51.40 KB, patch)
2011-11-14 14:20 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (23.97 KB, patch)
2011-11-14 16:03 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (19.67 KB, patch)
2011-11-17 11:52 PST, Adam Barth 		abarth: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-11-14 14:20:55 PST
Created attachment 115030 [details] Patch
Adam Barth
Comment 2 2011-11-14 15:09:51 PST
Comment on attachment 115030 [details] Patch Eric convinced me to do the drag-drop-dead-frame.html changes separately.
Adam Barth
Comment 3 2011-11-14 16:03:13 PST
Created attachment 115052 [details] Patch
Eric Seidel (no email)
Comment 4 2011-11-14 16:18:12 PST
Comment on attachment 115052 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115052&action=review LGTM. > LayoutTests/fast/frames/resources/sandboxed-iframe-storage-disallowed.html:5 > +<script> > +if (window.layoutTestController) > + layoutTestController.dumpAsText(); Would be nice to have a comment here about why we inline this.
Adam Barth
Comment 5 2011-11-14 16:24:39 PST
Committed r100213: <http://trac.webkit.org/changeset/100213>
Tony Gentilcore
Comment 6 2011-11-15 03:11:24 PST
Reopening due to rollback, see bug 72371.
Adam Barth
Comment 7 2011-11-16 20:11:53 PST
Those Chromium file API tests are blocking this patch, which is blocking a larger security cleanup tracked in Bug 71745.
Adam Barth
Comment 8 2011-11-17 11:48:42 PST
I'm going to try landing this again with a quirk for the storage identifier. This keeps the filesystem tests (both layout and unit) working as before. It's slightly ugly, but it lets us move forward with the general program of tightening up the SecurityOrigin implementation. I'll need to figure out how this impacts Bug 72342 once this lands.
Adam Barth
Comment 9 2011-11-17 11:52:36 PST
Created attachment 115644 [details] Patch for landing
Adam Barth
Comment 10 2011-11-17 13:34:46 PST
Committed r100663: <http://trac.webkit.org/changeset/100663>
Note You need to log in before you can comment on or make changes to this bug.