Bug 72269 - media/track/track-cues-cuechange.html is flaky
Summary: media/track/track-cues-cuechange.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anna Cavender
URL:
Keywords:
Depends on:
Blocks: 43668 70452
  Show dependency treegraph
 
Reported: 2011-11-14 06:39 PST by Tony Gentilcore
Modified: 2011-11-15 21:33 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.43 KB, patch)
2011-11-14 06:41 PST, Tony Gentilcore
no flags Details | Formatted Diff | Diff
change tests to check for order rather than timing (11.08 KB, patch)
2011-11-14 12:24 PST, Anna Cavender
no flags Details | Formatted Diff | Diff
Patch for landing (11.55 KB, patch)
2011-11-15 10:07 PST, Anna Cavender
no flags Details | Formatted Diff | Diff
make sure both video and track are ready to be tested (6.20 KB, patch)
2011-11-15 17:31 PST, Anna Cavender
no flags Details | Formatted Diff | Diff
Patch for landing (6.09 KB, patch)
2011-11-15 18:17 PST, Anna Cavender
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2011-11-14 06:39:37 PST
media/track/track-cues-cuechange.html has been flaky on all platforms (for chromium at least) since it was introduced by r100064.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Ftrack%2Ftrack-cues-cuechange.html 

I'm going to mark it flaky for now.
Comment 1 Tony Gentilcore 2011-11-14 06:41:38 PST
Created attachment 114937 [details]
Patch
Comment 2 Tony Gentilcore 2011-11-14 06:53:50 PST
Committed r100139: <http://trac.webkit.org/changeset/100139>
Comment 3 Anna Cavender 2011-11-14 12:24:00 PST
Created attachment 115003 [details]
change tests to check for order rather than timing
Comment 4 Anna Cavender 2011-11-15 10:07:20 PST
Created attachment 115187 [details]
Patch for landing
Comment 5 WebKit Review Bot 2011-11-15 11:15:11 PST
Comment on attachment 115187 [details]
Patch for landing

Clearing flags on attachment: 115187

Committed r100296: <http://trac.webkit.org/changeset/100296>
Comment 6 WebKit Review Bot 2011-11-15 11:15:16 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Peter Kasting 2011-11-15 16:39:07 PST
This patch made things worse rather than better, at least for the WebKit Mac 10.6 (CG) canary, where this patch made this test suddenly become much more flaky.

I'm going to re-mark this test as flaky.
Comment 8 Anna Cavender 2011-11-15 17:13:30 PST
Good catch.

Looks like this test needs to wait for both canplaythrough AND loaded (on <track>) the same way media/track/track-cues-seeking.html does.  I'm on it.
Comment 9 Anna Cavender 2011-11-15 17:31:26 PST
Created attachment 115287 [details]
make sure both video and track are ready to be tested
Comment 10 Anna Cavender 2011-11-15 18:17:44 PST
Created attachment 115291 [details]
Patch for landing
Comment 11 WebKit Review Bot 2011-11-15 18:53:19 PST
Comment on attachment 115291 [details]
Patch for landing

Rejecting attachment 115291 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
n/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/10361573
Comment 12 Anna Cavender 2011-11-15 21:33:50 PST
Committed r100402: <http://trac.webkit.org/changeset/100402>