Bug 72267 – [GTK][WEBKIT2] Add enable-caret-browsing property to WebKitSettings

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Mario Sanchez Prada]

We need this to allow enabling/disabling this mode from WebKit2GTK+ based browsers, as it used to be with WebKit1.

Caret browsing is an important feature rom the accessibility point of view, so the sooner we have this in WebKit2GTK+, the better :-)

[Mario Sanchez Prada]

We depend on having proper support for the caretBrowsingEnabled preference in WebKit2 C API.

[Mario Sanchez Prada]

Created attachment 114945 [details]
Patch proposal

Patch proposal, assuming bug 72266 has been fixed.

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Gustavo Noronha (kov)]

Comment on attachment 114945 [details]
Patch proposal

Attachment 114945 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10472267

[Mario Sanchez Prada]

(In reply to comment #4)
> (From update of attachment 114945 [details])
> Attachment 114945 [details] did not pass gtk-ews (gtk):
> Output: http://queues.webkit.org/results/10472267

Yeah, it doesn't pass since it needs WK2 API that is not available yet. See bug 72267, as soon as it gets fixed this patch should be valid.

[Carlos Garcia Campos]

Comment on attachment 114945 [details]
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=114945&action=review

Looks good to me.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:615
> +    /**
> +    * WebKitSettings:enable-caret-browsing:
> +    *

indentation is wrong here.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:616
> +    * Whether to enable caret browsing mode.

hmm, maybe you could explain a bit what caret browsing means, or use "accessibility enhanced keyboard navigation" here too.

[Mario Sanchez Prada]

Created attachment 114949 [details]
Patch proposal

(In reply to comment #6)
> [...]
> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:615
> > +    /**
> > +    * WebKitSettings:enable-caret-browsing:
> > +    *
> indentation is wrong here.

Fixed.

> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:616
> > +    * Whether to enable caret browsing mode.
> 
> hmm, maybe you could explain a bit what caret browsing means, or use "accessibility enhanced keyboard navigation" here too.

Done.

[Gustavo Noronha (kov)]

Comment on attachment 114949 [details]
Patch proposal

Attachment 114949 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10397238

[Mario Sanchez Prada]

Created attachment 114961 [details]
Patch proposal

Resubmitted to force EWS pass again, now that bug 72266 has been fixed

[Philippe Normand]

Comment on attachment 114961 [details]
Patch proposal

Looks good to me as well!

[Martin Robinson]

Comment on attachment 114961 [details]
Patch proposal

Yaaaaaay! Please verify that this doesn't introduce any new gtkdoc errors before landing by running Source/WebKit2/UIProcess/API/gtk/docs after building. Thanks!

[Mario Sanchez Prada]

Committed r100248: <http://trac.webkit.org/changeset/100248>